Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - "You appear to be offline" message and grey indicator are missing, chat conversation is not shown when user is offline #10424

Closed
kbecciv opened this issue Aug 17, 2022 · 9 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Aug 17, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. After login in with a High Traffic account - enable Airplane mode to simulate a connection loss

Expected Result:

The user can interact with the app and navigate to different areas
The offline indicators are present - the green dot next to the main user avatar is now grey
When navigating to a conversation there's a text below the compose box indicating that there's no internet connection

Actual Result:

"You appear to be offline" message is missing and chat conversation is not shown when user is offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.88.13

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5691832_HT_offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Aug 17, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2022

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@yuwenmemon
Copy link
Contributor

@yuwenmemon
Copy link
Contributor

Gonna close. I don't think this is consistently reproducible 😕

@kbecciv
Copy link
Author

kbecciv commented Aug 24, 2022

@yuwenmemon Issue have been reproduced during QA Regression, build 1.1.89.0

Screenshot_20220824-144231

@sketchydroide
Copy link
Contributor

cannot reproduce this in version 1.1.89.0 in desktop, Web, iOS or Android

As far as I can tell this is the exact same behaviour in Prod.

Either that or the description is wrong, it says the message you appear to be offline appears in all platforms.
Not sure on the green/gray dot, but I do not see that dot in Prod

@sketchydroide
Copy link
Contributor

I don't think this is consistently reproduced so I'm going to remove blocker

@sketchydroide sketchydroide added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 24, 2022
@sketchydroide
Copy link
Contributor

this one seems to be the same issue #10524?

@neil-marcellini
Copy link
Contributor

I'm closing this since I'm merging it into #10524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants