Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN- Unread message is not displayed in bold after reply by email #10736

Closed
kbecciv opened this issue Sep 1, 2022 · 17 comments
Closed

LHN- Unread message is not displayed in bold after reply by email #10736

kbecciv opened this issue Sep 1, 2022 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@kbecciv
Copy link

kbecciv commented Sep 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Go to chat.expensify.com and log in as account A
  3. As account A send some messages to an account that must be a main email address without the +. Wait 10 minutes. This will trigger an email notification to this account
  4. Log out of Account A
  5. After 10 min has passed, check the main account email inbox and open the mail with this name "Chat between and ".
  6. Answer to the email with any message.
  7. Wait a minute or 2 and log into both accounts (A and main account).

Expected Result:

Unread message is displayed in bold after reply by email

Actual Result:

Unread message is not displayed in bold after reply by email

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.95.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220831-132118_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2022

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2022

@johnmlee101 Eep! 4 days overdue now. Issues have feelings too...

@johnmlee101
Copy link
Contributor

Not sure if this is a front or back-end issue will investigate

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

@johnmlee101 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

@johnmlee101 Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

@johnmlee101 10 days overdue. I'm getting more depressed than Marvin.

@johnmlee101
Copy link
Contributor

I believe this issue is because the response trigger when we use the email isn't kicking off the unread indicator properly, but I also think we're doing a lot of changes to the LHN and unread messages so going to hold on solving this since its also has a small effect on the app

@melvin-bot melvin-bot bot removed the Overdue label Sep 20, 2022
@johnmlee101 johnmlee101 added Weekly KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 labels Sep 20, 2022
@MitchExpensify
Copy link
Contributor

I wonder if this is related to reports from Guides that no new messages in #admins or are showing in bold as unread in LHN

@marcaaron
Copy link
Contributor

Just adding that the message would not be bold for the person who sent it. That expectation is 100% wrong. If you send a message and then log in as the person who sent it the chat should be marked as read.

@melvin-bot melvin-bot bot added the Overdue label Sep 29, 2022
@johnmlee101
Copy link
Contributor

Going to open this up to the pool, but I also think that the email triggers for this shouldn't be too hard to resolve on the backend

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Overdue labels Oct 18, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@zanyrenney zanyrenney removed their assignment Oct 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@nkuoch
Copy link
Contributor

nkuoch commented Oct 21, 2022

Sorry, too much on my plate, unassigning myself

@nkuoch nkuoch removed their assignment Oct 21, 2022
@nkuoch nkuoch added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2022

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Overdue and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Oct 21, 2022
@tjferriss tjferriss removed the Overdue label Oct 24, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 24, 2022
@tjferriss
Copy link
Contributor

I was not able to reproduce this. The unread message was bold when I came back to the account. This appears to be working as intended so I'm leaning towards closing this out.

Screen Shot 2022-10-24 at 12 34 52 PM

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

@tjferriss Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tjferriss
Copy link
Contributor

Ok I'm going to close this out. Please reopen if you can reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

9 participants