Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences- Use staging server is not on by default. #10963

Closed
kavimuru opened this issue Sep 13, 2022 · 9 comments
Closed

Preferences- Use staging server is not on by default. #10963

kavimuru opened this issue Sep 13, 2022 · 9 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Sep 13, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing #10935

Action Performed:

  1. Open app
  2. Log in any account
  3. Go to Settings -> Preference
  4. Verify that Use staging server switch in on by default

Expected Result:

Use staging server should be enabled by default

Actual Result:

Use staging server is not on by default

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.2.0-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5729954_10935_mWeb.mp4
Bug5729954_10935_ios.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Santhosh-Sellavel
Copy link
Collaborator

Seems the changes are not updated.

Unsure why?

Screenshot 2022-09-13 at 10 13 20 PM

I believe that's the reason for this regression!
cc: @mountiny

@mountiny
Copy link
Contributor

This is a problem with our GH CD/CI which we encountered already once before. Discussing internally in Slack here

@MonilBhavsar
Copy link
Contributor

@mountiny the code didn't get deploy properly and caused this issue?

@mountiny
Copy link
Contributor

Correct, there is a problem in our deploy process so this did not cause the problem, it is just that the code which should have fix this was not part of the staging release (even though it should). You can read more in the Slack, it is quite weird thing

@mountiny mountiny self-assigned this Sep 15, 2022
@mountiny
Copy link
Contributor

I can confirm now this should be fixed now 🙇

@MonilBhavsar
Copy link
Contributor

Yes that's weird. Thanks for clarifying!

@mountiny
Copy link
Contributor

No problemo

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants