[HOLD #11768] Web - Pressing back after refresh dismisses the modal on many pages @Puneet-here

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Navigate to settings > workspace > manage members
3. Press Invite
4. Reload the page and press < (back button)

Expected Result:

You should get navigated to the manage members page

Actual Result:

The modal closes

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.9.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-09-20.at.9.05.55.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @Puneet-here

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663688205718319

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

We have to use Navigation.navigate(Route) at onBackButtonPress for the HeaderWithCloseButton on the pages where this issue is present, we need to add the Route where we want to navigate on pressing back.

This is the list of pages-

1. Connect bank account page
2. Debit card page
3. Invite new members page
4. Change password page

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[Christinadobrzyn]

I think this might be related to #11461 and #11429 and #11372 so I'm not sure if we want to solve this separately or if this will solve with those other ones.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Putting this on HOLD for this tracking issue. cc @puneetlath

[melvin-bot]

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[tjferriss]

I was able to reproduce this on webs staging (v1.2.18-2). Looks like the issue is still here.

[JmillsExpensify]

Switching out weekly for monthly given that the navigation project is large and has no defined ETA.

[JmillsExpensify]

Still on hold for the navigation reboot.

[JmillsExpensify]

Same same.

[JmillsExpensify]

Still on hold.

[JmillsExpensify]

Still on hold

[JmillsExpensify]

Coming off hold very soon!

[JmillsExpensify]

Working on testing this week.

[JmillsExpensify]

Still trying to make time. Low priority.

[JmillsExpensify]

Re-tested and this has been successfully fixed.

[JmillsExpensify]

@Puneet-here I just sent you an offer via Upwork. Please accept and we'll get you paid out and close the issue.

[JmillsExpensify]

Gentle bump when you get a chance.

[Puneet-here]

Accepted!

[JmillsExpensify]

Thanks. Offer paid!