Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-02-01] mWeb - Connect Bank account - User can't procced with Chase credentials for special scenario #12123

Closed
kbecciv opened this issue Oct 25, 2022 · 52 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 25, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Log in with a applause.expensifail account (that does not have any bank account already added)
  2. Enable staging Web secure server in Account Preferences if disabled
  3. Navigate to the add bank account modal (Workspace settings > Add bank account)
  4. Verify the Add bank account modal is displayed with 2 options to add bank accounts (Log in and Manual)
  5. Select the Connect with plaid method to add a bank account
  6. On the bank account list select "Chase"
  7. You'll be redirected to the "First Platypus Bank"
  8. Enter the credentials "user_good / pass_good"
  9. If a verification is prompted - select mobile and enter "credentials_good" as the verification mode
  10. Checkmark the "Plaid Checking" and "Plaid Saving"
  11. Checkmark the 2 options under "additional information you want to share"
  12. Click on continue

Expected Result:

User is able to proceed with Chase credentials for special scenario

Actual Result:

User can't procced with Chase credentials for special scenario

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS - blocked to check due to KI
  • Android - blocked to check due to KI
  • Mobile Web

Version Number: 1.2.19.1

Reproducible in staging?: Yes

Reproducible in production?: n/a

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20221024-183029_Chrome.2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering Daily KSv2 labels Oct 25, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2022

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2022

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 25, 2022
@kbecciv
Copy link
Author

kbecciv commented Oct 25, 2022

Please attached the link to TR for special scenario https://expensify.testrail.io/index.php?/cases/view/1971142

@PauloGasparSv
Copy link
Contributor

Having some trouble with VBA locally after clearing my db (want to try this locally), will debug this alongside another VBA issue tomorrow morning!

@zanyrenney
Copy link
Contributor

@PauloGasparSv I don't know why i have been assigned here, I don't think I should be! I am removing my assignment as this has got engineering assignment.

@zanyrenney zanyrenney removed their assignment Oct 26, 2022
@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Oct 27, 2022

Still couldn't figure out this problem and didn't have time to check it today : / , will ask team for help tomorrow if I keep stuck!

@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

@PauloGasparSv Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

@PauloGasparSv Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

Triggered auto assignment to @neil-marcellini (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

@PauloGasparSv
Copy link
Contributor

Not being redirected back to the same screen but getting a success message instead and being redirected to the routing number page (first page of the "connect manually" flow)

Checking locally if that's intended right now.

Screen.Recording.2022-10-31.at.16.17.05.mov

@PauloGasparSv
Copy link
Contributor

Sorry @neil-marcellini, I think I missclicked the demolition label!

@PauloGasparSv
Copy link
Contributor

@kbecciv do you mind re-testing this so I can have a new request to take a look at LogSearch?

My staging failed attempt looks completely different and locally I can get past the "Choose the account" screen.

@melvin-bot melvin-bot bot added the Overdue label Nov 3, 2022
@PauloGasparSv
Copy link
Contributor

@kbecciv just re-tested on my physical device in staging and I did not get the same behavior as the evidence video.

WhatsApp.Video.2022-11-03.at.4.30.57.PM.mp4

Can you re-test? And if it fails, can you send me the email of the applause.expensifail account you are using and in which vault it exists, cause I couldn't find it here.

@melvin-bot melvin-bot bot removed the Overdue label Nov 3, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 4, 2022

@PauloGasparSv Checking, update you shortly with results

@kbecciv
Copy link
Author

kbecciv commented Nov 4, 2022

Re-tested with build 1.2.23.9 and had different behavior this time - it directed to log in page.
Credentials used: [email protected]/Feya86Katya

Screen_Recording_20221104-111939_Chrome.mp4

@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2022
@nkuoch
Copy link
Contributor

nkuoch commented Dec 12, 2022

Bump @kbecciv

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2022
@kbecciv
Copy link
Author

kbecciv commented Dec 12, 2022

@nkuoch Checking now, will update you shortly

@kbecciv
Copy link
Author

kbecciv commented Dec 12, 2022

@nkuoch Credentials used:
[email protected]/Feya86Katya
User cannot proceed with Chase credentials for special scenario - flow directed to Plaid again.

Screen_Recording_20221212-095050_Chrome.1.mp4

@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Dec 12, 2022

I'll test this again in my physical device and the Android emulator, but in the iOS Simulator mweb and my Desktop Web I was able to proceed all the way to the routing and account number page with those credentials.

Screen.Recording.2022-12-12.at.15.41.27.mov

btw: I think the credentials had a missing p and an extra a in the email so here they are updated: [email protected]/Feya86Katya

@kbecciv
Copy link
Author

kbecciv commented Dec 12, 2022

@PauloGasparSv Sorry, over typed the email, updated it

@nkuoch
Copy link
Contributor

nkuoch commented Dec 13, 2022

@PauloGasparSv I can take over , I'm currently doing a refactoring of the flow and believe it will fix this too.

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Dec 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 21, 2022

@nkuoch Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Dec 23, 2022

@nkuoch Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Dec 27, 2022

@nkuoch 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Dec 29, 2022

@nkuoch 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 3, 2023

This issue has not been updated in over 14 days. @nkuoch eroding to Weekly issue.

@melvin-bot
Copy link

melvin-bot bot commented Jan 24, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 25, 2023
@melvin-bot melvin-bot bot changed the title mWeb - Connect Bank account - User can't procced with Chase credentials for special scenario [HOLD for payment 2023-02-01] mWeb - Connect Bank account - User can't procced with Chase credentials for special scenario Jan 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 25, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jan 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-02-01. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2023
@nkuoch nkuoch closed this as completed Feb 6, 2023
@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants