Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-02-03] [$4000] Chat - The Paragraphs are not displayed and some spaces missing between text after copied test from the opened HTML file #12155

Closed
kbecciv opened this issue Oct 26, 2022 · 64 comments
Closed

[HOLD for payment 2023-02-03] [$4000] Chat - The Paragraphs are not displayed and some spaces missing between text after copied test from the opened HTML file #12155

kbecciv opened this issue Oct 26, 2022 · 64 comments
Assignees
@tgolen @davidcardoza @thesahindia
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 26, 2022 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Issue found when executing PR #11926

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Select any chat
  4. Open HTML file in another tab
  5. Copy and paste as is
  6. Send it

Expected Result:

The Paragraphs and spaces between text are displayed after copied test from the opened HTML file

Actual Result:

The Paragraphs are not displayed and some spaces missing between text after copied test from the opened HTML file

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.19.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

11926.Web1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ca19ac6a046e22d6
  • Upwork Job ID: 1613324508306006016
  • Last Price Increase: 2023-01-25
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2022

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Gonals Gonals removed their assignment Oct 27, 2022
@Gonals Gonals added Weekly KSv2 Improvement Item broken or needs improvement. External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels Oct 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

Triggered auto assignment to @davidcardoza (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

Triggered auto assignment to @tgolen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Gonals
Copy link
Contributor

Gonals commented Oct 27, 2022

Marking as external!

@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2022
@tgolen
Copy link
Contributor

tgolen commented Nov 7, 2022

Waiting for proposals. Bumping up to daily

@tgolen tgolen added Daily KSv2 and removed Weekly KSv2 Overdue labels Nov 7, 2022
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 11, 2022

@tgolen, @davidcardoza, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Santhosh-Sellavel
Copy link
Collaborator

We are still waiting for proposals here! Maybe we should double this @davidcardoza please post the Upwork job! Maybe we could get some proposals! I think we could start this job for $500 or $1000!

cc: @tgolen!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 12, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Not overdue!

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2023
@thesahindia
Copy link
Member

@davidcardoza, this is ready for payments. Also the job is no longer available, can you please look into it.

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2023
@thesahindia
Copy link
Member

bump @davidcardoza

@eh2077
Copy link
Contributor

eh2077 commented Feb 14, 2023

Hi @davidcardoza , would you like to have a look on this when you have time?

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2023
@tgolen
Copy link
Contributor

tgolen commented Feb 21, 2023

Reaching out to @davidcardoza to bump him directly

@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2023
@davidcardoza
Copy link
Contributor

@thesahindia Can you apply for the job here - https://www.upwork.com/jobs/~0159082963148d6a33 I was unable to find you in Upwork to hire you.

@thesahindia
Copy link
Member

Applied, thanks!

@eh2077
Copy link
Contributor

eh2077 commented Mar 1, 2023

bump @davidcardoza

@melvin-bot melvin-bot bot added the Overdue label Mar 2, 2023
@tgolen
Copy link
Contributor

tgolen commented Mar 3, 2023

bump @davidcardoza

@melvin-bot melvin-bot bot removed the Overdue label Mar 3, 2023
@dylanexpensify
Copy link
Contributor

I'll take care of payments!

@dylanexpensify
Copy link
Contributor

Alrighty, @eh2077 and @thesahindia payments sent and contracts ended! @davidcardoza I'll leave it to you to do the regression test bits!

@dylanexpensify
Copy link
Contributor

Sorry, missed that this should be $1K. Requesting partial refunds!

  • Sent: $3,000 ($2K + $1K for speed bonus)
  • Actual: $1,500 ($1K + $500 for speed bonus)
  • Refund request amount: $1,500

@thesahindia
Copy link
Member

It was a new feature. Here are the steps for this test case -

  1. Go to https://codepen.io/pen/
  2. Paste the given html at in the html file
<html>
<body>
    <h1>HTML paragraphs and unordered list copy test</h1>
    <p>This is a HTML paragraph</p>
    <br>
    <p>An Unordered HTML List</p>
    <ul>
        <li><a href="https://example.com">Coffee</a> -- Coffee</li>
        <li><a href="https://example.com">Tea</a> -- Tea</li>
        <li><a href="https://example.com">Milk</a> -- Milk</li>
    </ul>
</body>
</html>
  1. Copy the rendered content
  2. Open new dot > Go to a chat
  3. Paste the copied content and send it
  4. Verify that <p> tag displays in newline and <li> item displays in newline with 2 prefix spaces

@thesahindia
Copy link
Member

bump @davidcardoza! We need to add the regression tests so that we can close this issue.

@melvin-bot melvin-bot bot added the Overdue label Mar 22, 2023
@tgolen
Copy link
Contributor

tgolen commented Apr 3, 2023

@davidcardoza this is still waiting on you

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2023
@tgolen
Copy link
Contributor

tgolen commented Apr 12, 2023

Bumping @davidcardoza 1:1

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2023
@davidcardoza
Copy link
Contributor

Regression test being added here - https://github.com/Expensify/Expensify/issues/275543

@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2023
@tgolen
Copy link
Contributor

tgolen commented Apr 21, 2023

Looks like this can be closed now

@tgolen tgolen closed this as completed Apr 21, 2023
@melvin-bot melvin-bot bot removed the Overdue label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgolen tgolen

@davidcardoza davidcardoza

@thesahindia thesahindia

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests