Room name doesn't register special characters instead of throwing error

[puneetlath]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. Choose New Room from the create menu
2. Type in a special character (e.g. ! or . in the room title

Expected Result:

Describe what you think should've happened
The special character that was typed is shown, along with a validation error saying that character is not allowed.

Actual Result:

Describe what actually happened
The character is not shown at all.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.2.26-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668173276175579?thread_ts=1668112427.854869&cid=C049HHMV9SM

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[puneetlath]

@lschurr I'll fix this.

[puneetlath]

Will start on this today.

[lschurr]

Cool @puneetlath - do I need to do anything? Should I be trying to reproduce?

[puneetlath]

Nope, it's reproducible.

[lschurr]

Heyooooo any updates on this one @puneetlath?

[puneetlath]

I realized I need to refactor this page to use the new Forms component, so it's a little bit more involved then I initially thought. Hope to have a PR up today.

[puneetlath]

Still working on this, should be done soon.

[melvin-bot]

@puneetlath, @lschurr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[lschurr]

@puneetlath - you're OOO this week right?

[lschurr]

Gonna move to Weekly since Puneet is OOO.

[muttmuure]

Also assigning myself since I'm managing the tracking issue here

[puneetlath]

Still on hold, now for #13915

[melvin-bot]

Triggered auto assignment to @davidcardoza (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[puneetlath]

@davidcardoza we need some error copy for when someone tries to enter an invalid room name. We only allow letters, numbers, and dashes in room names. All other characters are disallowed. I'm thinking:

Room names cannot contain punctuation or most special characters

For reference, here is Slack's:

How does that sound?

[davidcardoza]

How about this, just a slight addition:

Room names cannot contain spaces, punctuation or most special characters

I think most users will try to create a room with spaces, but that's just my opinion.

[puneetlath]

If they try to enter a space we automatically replace it with a dash. So I don't think we need to include that.

[davidcardoza]

That's awesome, I didn’t know that. Your copy looks good to me in that case.

[puneetlath]

@lschurr FYI this is internal, but @rushatgabhane is helping out with PR review and will need to be paid out (once this goes live).

[lschurr]

@rushatgabhane could you apply for the job in Upwork? https://www.upwork.com/jobs/~01f8eb2fdbe370c1ac

[rushatgabhane]

@lschurr thanks! I've applied

[lschurr]

Hey @puneetlath - Is this live? Should I pay and close this out or are we still waiting on something?

[puneetlath]

Yes! The PR hit production on Jan 9 so you're good to pay out @rushatgabhane on this one.

[lschurr]

Awesome. Paid!