-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat - Emojis are switching from big size to small #13292
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @marcaaron ( |
I don't see anything obvious in the staging PRs list |
Could it be caused by this -> #12968 ? Not really sure what controls the size of these emojis and will have to look into that first |
Also cc @stitesExpensify as "the emoji guy" just in case 😄 |
Posting in Slack about this here. Stumped on what the root cause could be. |
This is probably self resolved (trying to confirm but staging is slooow). The Web-Expensify PR https://github.com/Expensify/Web-Expensify/pull/35658 dealing with these changes was deployed just 5 hours ago to staging. The same changes were applied to the front in these two PRs: #12968 and Expensify/expensify-common#474 and were deployed to staging 3 days ago. This made the backend and frontend produce inconsistent results when converting from |
Oh nice so... can we close? |
It looks like we can |
Yes, I was just waiting to confirm that this is not happening in staging, but I haven't been able. I'll reopen if I see that this still happening. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #12968
Action Performed:
3.1 Add an emoji
3.2 Add two or more empty lines
3.3.Add an emoji
Offline testing
3.1. Add an emoji
3.2 Add two or more empty lines
3.3 Add an emoji
Expected Result:
Emojis should be the same size
Actual Result:
Emojis are switching from big size to small
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.36.0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
12968.Android.mp4
Bug5845855_Screen_Recording_20221202-163213_New_Expensify.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: