Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Emojis are switching from big size to small #13292

Closed
kbecciv opened this issue Dec 2, 2022 · 11 comments
Closed

Chat - Emojis are switching from big size to small #13292

kbecciv opened this issue Dec 2, 2022 · 11 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Dec 2, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #12968

Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Compose a message by:
    3.1 Add an emoji
    3.2 Add two or more empty lines
    3.3.Add an emoji
  4. Send it

Offline testing

  1. Go to a chat
  2. Go offline, this way we make sure you are seeing the data produced by the frontend and not what came from the backend
  3. Compose a message by:
    3.1. Add an emoji
    3.2 Add two or more empty lines
    3.3 Add an emoji
  4. Send the message
  5. Back online

Expected Result:

Emojis should be the same size

Actual Result:

Emojis are switching from big size to small

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.36.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

12968.Android.mp4
Bug5845855_Screen_Recording_20221202-163213_New_Expensify.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 2, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Dec 2, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Dec 2, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

I don't see anything obvious in the staging PRs list

@marcaaron
Copy link
Contributor

Could it be caused by this -> #12968 ?

Not really sure what controls the size of these emojis and will have to look into that first

@marcaaron
Copy link
Contributor

Are these fonts? Could it be related to this -> 08fa35d @Luke9389

@marcaaron
Copy link
Contributor

Also cc @stitesExpensify as "the emoji guy" just in case 😄

@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2022
@marcaaron
Copy link
Contributor

Posting in Slack about this here. Stumped on what the root cause could be.

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2022
@aldo-expensify aldo-expensify self-assigned this Dec 5, 2022
@marcaaron marcaaron removed their assignment Dec 5, 2022
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Dec 5, 2022

This is probably self resolved (trying to confirm but staging is slooow).

The Web-Expensify PR https://github.com/Expensify/Web-Expensify/pull/35658 dealing with these changes was deployed just 5 hours ago to staging. The same changes were applied to the front in these two PRs: #12968 and Expensify/expensify-common#474 and were deployed to staging 3 days ago. This made the backend and frontend produce inconsistent results when converting from html to text and when creating lastMessageText, but this should not be the case anymore for staging.

@marcaaron
Copy link
Contributor

Oh nice so... can we close?

@Luke9389
Copy link
Contributor

Luke9389 commented Dec 5, 2022

It looks like we can

@marcaaron marcaaron closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
@aldo-expensify
Copy link
Contributor

Yes, I was just waiting to confirm that this is not happening in staging, but I haven't been able. I'll reopen if I see that this still happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants