[HOLD #15244] Web - Storybook site - The storybook site opens with error in console

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #13916

Action Performed:

1. Visit staging.new.expensify.com/docs/index.html
2. Verify the storybook site looks normal

Expected Result:

The storybook site opens without error in console

Actual Result:

The storybook site opens with error in console

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.2.69.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5932195_13916_Web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017f7e671d8cdea696
• Upwork Job ID: 1625137872852045824
• Last Price Increase: 2023-02-13

[MelvinBot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

Asking for a second opinion on what to do about these. In the meantime, I can see these errors on Mac chrome web as well:

[trjExpensify]

There's another CSP issue here that has recently been put on hold. Asking on that issue whether we proceed with this, close it or if it should be held.

[techievivek]

This is related to the storybook 6 telejson package that uses eval. More here

There is no way we are going to update our CSP rule to allow eval but we can configure storybook to help us fix this. storybookjs/storybook#12364 (comment)

I can give it a try fixing this but we will need to test this on staging.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~017f7e671d8cdea696

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

[techievivek]

Putting this on HOLD as well based on Rory's comments, as it would be a pain testing this. We can look into it when we have moved the worker code to the newDot repo.

[trjExpensify]

Sweet, sounds good!

[trjExpensify]

Switching to weekly while on hold. @techievivek is there an issue number to include in the title?

[techievivek]

@trjExpensify we don't seem to have any tracking issues yet for CSP errors.

[trjExpensify]

Same, held on server migration.

[techievivek]

On hold for migrating newDot from AWS to our own servers.

[trjExpensify]

Still held on the migration!

[trjExpensify]

Still on hold for migrating NewDot from AWS to our own servers, Melv!

[trjExpensify]

Still on hold for migrating NewDot from AWS to our own servers, Melv!

[trjExpensify]

@techievivek, looks like we should be able to proceed with this issue in short order. Can you address Justin's question here so we can keep it moving?

[techievivek]

Sorry, I wasn't able to prioritize this. I will have the GH ready for Justin by this week, which can help us test CSP changes locally.

[trjExpensify]

What's the story here @techievivek? Did you get that GH ready?

[techievivek]

Sorry, with budget and retention whispers EOY projects, I couldn't prioritize this. Considering our current# focus and the fact that this doesn't seem to be a blocking issue, I am uncertain if it's worth investing time in at the moment. Let me know what you think about it, thanks.

[trjExpensify]

If the use of Storybook isn't impacted by this console error, I can see closing this out if there isn't a wider CSP concern we need to address either.

[techievivek]

Sure, the issue doesn't affect the functionality of the storybook portal itself. It only seems to affect the loading of certain resources, specifically some Plaid/Onfido resources. I'm going to close this for now. When we have more time to address lower priority tasks, I'll investigate this further. Thanks.