Payments - Modal is not dismissed as soon as the payment method is Set as Default on the original device

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #14869

Action Performed:

1. Log in in Web
2. Go to Setting - Add Payment Method
3. Select Bank Account
4. Use Fidelity
5. Select Saving 1111
6. Save and Continue
7. You will see bank add under you payment
8. Log in with mWeb with the same account
9. Go to Setting - Payments
10. Tap on Fidelity Saving 1111
11. Make as Default Payment

Expected Result:

Modal is dismissed as soon as the payment method is Set as Default on the original device

Actual Result:

Modal is not dismissed as soon as the payment method is Set as Default on the original device

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.69.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5932364_14869_mWeb__1_.mp4

Bug5932364_Screen_Recording_20230210_094044_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

@kbecciv just to clarify, the bug is that you are getting an error when attempting to set the payment method as your default payment method, is that right?

If so, I think this is a #passwordless issue and should be handled in https://github.com/Expensify/Expensify/issues/261738.

@NikkiWines @johnmlee101 do you agree?

[kbecciv]

No, the problem is that the modal is not dismissed as soon as the payment method is Set as Default on the original device

[kbecciv]

This is PR #14869

[puneetlath]

@kbecciv I'm confused. In your video, the default payment method doesn't get set. There is an error when you try to do it.

[MelvinBot]

@puneetlath Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

[puneetlath]

Ok I just tested this locally. The modal isn't dismissed when you do set default, but based on the test steps in the PR, that is expected. However, when I did delete the payment method, the modal was dismissed. So I think we're good here. Reopen if you disagree!