[$1000] mWeb/safari - IOU - Endless spinner displayed when open the Detail page while offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Pre: Account A requested money from Account B

1. Login to account B on mweb
2. Disable the internet connection on the device
3. Tap on Pay button

Expected Result:

NO endless spinner displayed when open the Detail page while offline

Actual Result:

Endless spinner displayed when open the Detail page while offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.77.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1677604368.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fcbd7caeb271e664
• Upwork Job ID: 1631151597307060224
• Last Price Increase: 2023-03-02

[MelvinBot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[stephanieelliott]

This one seems like it can be worked on by an external contributor!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01fcbd7caeb271e664

[MelvinBot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[MelvinBot]

Triggered auto assignment to @madmax330 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

The IOU details page design will be changed completely here and I think we should hold for it.

[osofus]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Endless spinner is displayed when trying to pay using PayPal when offline.

What is the root cause of that problem?

The app is trying to open a paypal.me URL, which is not possible, since the app is offline.

This is happening in functions sendMoneyViaPaypal in IOU.js:
asyncOpenURL(Promise.resolve(), buildPayPalPaymentUrl(amount, recipient.payPalMeAddress, currency));

& payMoneyRequestViaPaypal in IOU.js:
asyncOpenURL(Promise.resolve(), buildPayPalPaymentUrl(iouReport.total, recipient.payPalMeAddress, iouReport.currency));

What changes do you think we should make in order to solve the problem?

The above asyncOpenURL function should be called only if network is available.

[thesahindia]

The IOU details page design will be changed completely here and I think we should hold for it.

Thanks for the information @bernhardoj!

@madmax330, should we put this on hold?

[madmax330]

@thesahindia I think this might be a dupe of that issue since in the comments I see a lot of discussion about the endless spinner.
cc @dangrous what do you think, is this a dupe, should we put it on hold?

[madmax330]

seems @dangrous is OOO this might be a dupe, tagging others from that issue for your thoughts @shawnborton @JmillsExpensify @trjExpensify

[trjExpensify]

oh hm, maybe. The idea on the hold for the other issue is to reduce the chance of conflicts if we were to introduce a skeleton UI for iouDetails when loading now. @Julesssss summarised it pretty succinctly here.

iouDetails should load when offline now though, I'm not sure why we're running into an endless spinner all of a sudden? 😕

[Julesssss]

I'm unable to reproduce on Android mWeb, are we sure this still exists?

android-offline.mp4

[Julesssss]

I think we should close, unless anyone else is able to reproduce this issue.

[osofus]

I can't reproduce either!

[trjExpensify]

For good measure, me neither on iOS Safari which it was reported on 👍