Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-03-20] Fix Static emoji autosuggestion issues #15968

Closed
6 tasks done
stitesExpensify opened this issue Mar 14, 2023 · 15 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@stitesExpensify
Copy link
Contributor

stitesExpensify commented Mar 14, 2023

This was found immediately after merging the emoji auto suggestion issue here. It was quickly fixed by @fedirjh here 🙇


Action Performed:

Type :+1

Expected Result:

The thumbs up emoji should show up

Actual Result:

The app crashes

Workaround:

Don't use thumbs up

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @fedirjh
Slack conversation: n/a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012f7356636061d878
  • Upwork Job ID: 1635750902645633024
  • Last Price Increase: 2023-03-14
@stitesExpensify stitesExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 14, 2023
@stitesExpensify stitesExpensify self-assigned this Mar 14, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 14, 2023
@MelvinBot
Copy link

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 14, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@stitesExpensify
Copy link
Contributor Author

This has already been fixed here #15871 (comment)

I'm just creating this so that we can pay the contributor for finding and fixing the bug quickly

@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Mar 14, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 14, 2023
@melvin-bot melvin-bot bot changed the title Fix Static emoji autosuggestion issues [$1000] Fix Static emoji autosuggestion issues Mar 14, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~012f7356636061d878

@MelvinBot
Copy link

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 14, 2023
@MelvinBot
Copy link

Current assignee @stitesExpensify is eligible for the External assigner, not assigning anyone new.

@stitesExpensify
Copy link
Contributor Author

This is already merged, no need for c+

@fedirjh
Copy link
Contributor

fedirjh commented Mar 14, 2023

Cc @stitesExpensify

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 15, 2023
@MelvinBot
Copy link

📣 @fedirjh You have been assigned to this job by @stitesExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@stitesExpensify stitesExpensify changed the title [$1000] Fix Static emoji autosuggestion issues [HOLD for payment 2023-03-20] Fix Static emoji autosuggestion issues Mar 15, 2023
@adelekennedy
Copy link

@fedirjh will you apply here so I can pay you out on the 20th?

@fedirjh
Copy link
Contributor

fedirjh commented Mar 19, 2023

@adelekennedy Done !!

@adelekennedy
Copy link

@fedirjh hired and ready to pay out!

@adelekennedy
Copy link

and done!

@fedirjh
Copy link
Contributor

fedirjh commented Mar 21, 2023

@adelekennedy Thank you . I think it's also eligible for bonus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants