Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD][$250] Migrate index.native.js to function component #16146

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 9 comments
Closed
1 task

[HOLD][$250] Migrate index.native.js to function component #16146

marcaaron opened this issue Mar 20, 2023 · 9 comments
Labels
Engineering Improvement Item broken or needs improvement.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.native.js to function component [HOLD][$250] Migrate index.native.js to function component Apr 13, 2023
@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@dummy-1111
Copy link
Contributor

I'd love to work on this.

@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I'd like to work on this issue

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this issue?

@mejed-alkoutaini
Copy link

I'm able to work on this if needed!

@mkhutornyi
Copy link
Contributor

I'd like to work on this.

@ghost
Copy link

ghost commented Jul 13, 2023

Dibs?

@KrAbhas
Copy link
Contributor

KrAbhas commented Jul 19, 2023

I can work on this

@shubham1206agra
Copy link
Contributor

Please close this #23854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engineering Improvement Item broken or needs improvement.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests
9 participants
@marcaaron @KrAbhas @shubham1206agra @rayane-d @mejed-alkoutaini @mkhutornyi @muxriddinmuqimov77 @dummy-1111 @vdem0115