Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-07-26] [$250] Migrate index.website.js to function component #16254

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 27 comments
Closed
1 task

[HOLD for payment 2023-07-26] [$250] Migrate index.website.js to function component #16254

marcaaron opened this issue Mar 20, 2023 · 27 comments
Assignees
@cristipaval @parasharrajat
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@cristipaval cristipaval self-assigned this Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.website.js to function component [HOLD][$250] Migrate index.website.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@marcaaron marcaaron changed the title [HOLD][$250] Migrate index.website.js to function component [$250] Migrate index.website.js to function component Apr 25, 2023
@marcaaron marcaaron added the Weekly KSv2 label Apr 25, 2023
@marcaaron
Copy link
Contributor Author

Gonna take this one off HOLD since the other one you did is almost closed out!

@melvin-bot melvin-bot bot added the Overdue label May 4, 2023
@cristipaval
Copy link
Contributor

Coming soon to this. I've been busy with Manual Requests which took me longer than expected.

@melvin-bot melvin-bot bot removed the Overdue label May 5, 2023
@melvin-bot melvin-bot bot added the Overdue label May 15, 2023
@cristipaval
Copy link
Contributor

Still focusing on urgent tasks for EC3

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@melvin-bot melvin-bot bot added the Overdue label May 23, 2023
@cristipaval
Copy link
Contributor

cristipaval commented May 25, 2023 •
edited
Loading

Getting to this soon. I postponed it a bit because there were still issues with the automatic authentication with the magic link and wanted to first get this part stable before refactoring it.

@melvin-bot melvin-bot bot removed the Overdue label May 25, 2023
@cristipaval cristipaval mentioned this issue May 30, 2023
Merged
57 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label May 30, 2023
@marcaaron marcaaron added Daily KSv2 and removed Weekly KSv2 labels Jun 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

@cristipaval Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

@cristipaval 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@cristipaval
Copy link
Contributor

Melvin, you ok?

@parasharrajat
Copy link
Member

PR on Hold on #20708. It was reverted but being worked on again whose changes are required in refactoring.

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

@cristipaval Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

@cristipaval Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

@cristipaval 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Jun 29, 2023

@cristipaval 10 days overdue. Is anyone even seeing these? Hello?

@parasharrajat
Copy link
Member

#20708 will be merged soon and then we can move forward here.

@melvin-bot melvin-bot bot removed the Daily KSv2 label Jul 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 4, 2023

This issue has not been updated in over 14 days. @cristipaval eroding to Weekly issue.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jul 4, 2023
@ghost
Copy link

ghost commented Jul 14, 2023

Dibs

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 19, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate index.website.js to function component [HOLD for payment 2023-07-26] [$250] Migrate index.website.js to function component Jul 19, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

@cristipaval Still overdue 6 days?! Let's take care of this!

@parasharrajat
Copy link
Member

@cristipaval Can you assign this issue to me as C+?

@parasharrajat
Copy link
Member

Payment requested.

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

@cristipaval Still overdue 6 days?! Let's take care of this!

@JmillsExpensify
Copy link

@cristipaval can you please confirm what the appropriate payment amount is for @parasharrajat. Thanks!

@cristipaval
Copy link
Contributor

cristipaval commented Aug 3, 2023 •
edited
Loading

@JmillsExpensify 250$ for the reviews of the issues related to [HOOK REFACTOR]

@melvin-bot melvin-bot bot removed the Overdue label Aug 3, 2023
@JmillsExpensify
Copy link

Reviewed details for @cristipaval. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

@parasharrajat
Copy link
Member

We can close this @cristipaval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristipaval cristipaval

@parasharrajat parasharrajat

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests
5 participants
@JmillsExpensify @MelvinBot @cristipaval @parasharrajat @marcaaron