Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-13] [$250] Migrate DateOfBirthPage.js to function component #16294

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 18 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@marcaaron
Copy link
Contributor

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@arosiclair arosiclair self-assigned this Mar 21, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@arosiclair arosiclair added the Monthly KSv2 label Apr 10, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate DateOfBirthPage.js to function component [HOLD] [$250] Migrate DateOfBirthPage.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@marcaaron marcaaron changed the title [HOLD] [$250] Migrate DateOfBirthPage.js to function component [$250] Migrate DateOfBirthPage.js to function component Apr 27, 2023
@marcaaron
Copy link
Contributor Author

Taking this off HOLD since we just merged the other PR you were working on @arosiclair

@arosiclair
Copy link
Contributor

Drafted a PR for this. Just need to do the checklist and post it

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label May 31, 2023
@marcaaron marcaaron added Daily KSv2 and removed Monthly KSv2 labels Jun 2, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 6, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate DateOfBirthPage.js to function component [HOLD for payment 2023-06-13] [$250] Migrate DateOfBirthPage.js to function component Jun 6, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 13, 2023
@arosiclair arosiclair added the Bug Something is broken. Auto assigns a BugZero manager. label Jun 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Expensify Expensify deleted a comment from melvin-bot bot Jun 15, 2023
@arosiclair
Copy link
Contributor

@twisterdotcom can you pay @allroundexperts for his C+ review so we can close this out? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Jun 15, 2023
@twisterdotcom
Copy link
Contributor

I can hopefully on Monday. I have been getting this error with Upwork for 2 days now: #19624 (comment).

@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@dylanexpensify
Copy link
Contributor

@allroundexperts can you apply here please? 🙇‍♂️

@twisterdotcom
Copy link
Contributor

Assigning Dylan because I am having issues accessing Upwork.

@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2023
@dylanexpensify
Copy link
Contributor

Offer sent @allroundexperts!

@allroundexperts
Copy link
Contributor

Assigning Dylan because I am having issues accessing Upwork.

Done!

@GiovanniCaiazzo01
Copy link

is this closed ?

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

📣 @GiovanniCaiazzo01! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@nitin-kukreti
Copy link

Hi I have see this task at upwork but I did not find any issue in this closed ?

@dylanexpensify
Copy link
Contributor

Hey team! We hired @allroundexperts for this one for tackling, thank you though!

@dylanexpensify
Copy link
Contributor

Payment sent! Thanks team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

8 participants