[HOLD for payment 2023-05-22] [$250] Migrate WorkspaceSettingsPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/workspace/WorkspaceSettingsPage.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

[marcaaron]

@dangrous taking this issue off HOLD as per this Slack post

IMPORTANT: If anything unexpected pops up during the refactor/review:

• Take it to #expensify-open-source to get clarification on.
• Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
• Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations”
• Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[dangrous]

Getting to this soon! It's like #3 on my list every day but 1 and 2 keep taking longer than expected. Almost certainly by EOW.

[dangrous]

On staging, should be on prod soon

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate WorkspaceSettingsPage.js to function component  #18299

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - N/A
• Contributor that fixed the issue - N/A
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[dangrous]

Getting a BugZero volunteer to handle payment for @sobitneupane's review!

[conorpendergrast]

Contract sent to @sobitneupane for this Upwork job: https://www.upwork.com/jobs/~015a58761a7f15a7ed

Once that's accepted, I'll pay that

[conorpendergrast]

It's been accepted, and paid!

@dangrous looks like we're all done. Anything else?

[dangrous]

I think we're good! Closing now - thank you!