[HOLD for payment 2023-04-12] Web - Chat - User can't type second ":" to finish emoji input in edit mode

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the application staging.new.expensify.com
2. Open any chat
3. Send a message that includes emojis
4. Edit the message with the emojis. Try to add new emojis

Expected Result:

User can successfully edit a message with an emoji. User can add a new emoji to the message.

Actual Result:

User can't type second ":" to finish emoji input in edit mode.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6004945_emoji-edit.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[fedirjh]

This is a regression from #16604 , this line

App/src/libs/EmojiUtils.js

Line 205 in df10eeb

let emojiReplacement = this.getEmojiCodeWithSkinColor(checkEmoji.metaData, preferredSkinTone);

This is caused a runtime error , We should remove the this. keyword and simply call the getEmojiCodeWithSkinColor function directly.

[garrettmknight]

Getting another engineer to take a look via slack.

[Beamanator]

@fedirjh your fix looks great! I'm not sure if you're available to implement the fix right now - so I will probably go ahead and implement it

[Santhosh-Sellavel]

@Beamanator Can you assign me this one thanks!

[thienlnam]

Tested and this passes QA #16902 (comment)

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.94-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove incorrect this from replaceEmojis function #16902

If no regressions arise, payment will be issued on 2023-04-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.95-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove incorrect this from replaceEmojis function #16902

If no regressions arise, payment will be issued on 2023-04-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Beamanator]

Not sure how this got "deployed" twice, but let's go with the original payment date, 04-12

[Santhosh-Sellavel]

@garrettmknight bump!

[garrettmknight]

Thanks! @Santhosh-Sellavel offer sent to you.

@fedirjh also sent you an offer since you proposed the solution we ended up going with.

[garrettmknight]

https://www.upwork.com/ab/applicants/1646862932045074432/job-details

[Santhosh-Sellavel]

@garrettmknight Offer says withdrawn can you send again thanks!

[garrettmknight]

Weird, just resent!

[garrettmknight]

Paid!

[fedirjh]

cc @garrettmknight , I am still seeing the contract as open with remaining milestone as unpaid , could you please verify
https://www.upwork.com/nx/wm/workroom/33331313/details

[garrettmknight]

@fedirjh sorry about that, just caught this notification after being out for a few months. Paid and closed.