Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2023-06-19] [Group 1][Accessible Pressable] Migrate IOUPreview #17010

Closed
roryabraham opened this issue Apr 6, 2023 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate IOUPreview to use PressableWithoutFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011f69f159446043ef
  • Upwork Job ID: 1671985573599035392
  • Last Price Increase: 2023-06-22
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 1][Accessible Pressable] Migrate IOUPreview [Group 1][Accessible Pressable] Migrate IOUPreview May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@robertKozik
Copy link
Contributor

I'm passing it in priority as in the meantime it TouchableWithoutFeedback was changed to Pressable
cc. @roryabraham

@roryabraham
Copy link
Contributor Author

Gotcha, priority lowered here.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 30, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jun 12, 2023
@melvin-bot melvin-bot bot changed the title [Group 1][Accessible Pressable] Migrate IOUPreview [HOLD for payment 2023-06-19] [Group 1][Accessible Pressable] Migrate IOUPreview Jun 12, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables Jun 19, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011f69f159446043ef

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@roryabraham roryabraham changed the title [$1000] [HOLD for payment 2023-06-19] [Group 1][Accessible Pressable] Migrate IOUPreview [$250] [HOLD for payment 2023-06-19] [Group 1][Accessible Pressable] Migrate IOUPreview Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Upwork job price has been updated to $250

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

📣 @sobitneupane You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@roryabraham
Copy link
Contributor Author

@johncschuster The only payment due here is $250 to @sobitneupane for the C+ review of the PR. @robertKozik works for SWM and will invoice us separately

@johncschuster
Copy link
Contributor

Thanks, @roryabraham!

In that case, @sobitneupane, can you apply to the job above when you get a chance? I'll get payment issued shortly!

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2023
@sobitneupane
Copy link
Contributor

Thanks, @johncschuster!

Applied for the job.

@johncschuster
Copy link
Contributor

Thanks, @sobitneupane! I've sent the offer. Give me a ping when you've accepted and I'll get the payment issued.

@sobitneupane
Copy link
Contributor

Thanks @johncschuster. Accepted the offer.

@melvin-bot melvin-bot bot added the Overdue label Jun 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2023

@johncschuster, @sobitneupane, @mountiny, @robertKozik Eep! 4 days overdue now. Issues have feelings too...

@mountiny
Copy link
Contributor

mountiny commented Jul 4, 2023

@sobitneupane has this been paid?

@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2023
@sobitneupane
Copy link
Contributor

@mountiny Nope. Not yet.

@mountiny
Copy link
Contributor

mountiny commented Jul 6, 2023

Bump @johncschuster thanks 🙇

@johncschuster
Copy link
Contributor

On it!

@johncschuster
Copy link
Contributor

Payment has been issued! Thanks for your patience, @sobitneupane!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

8 participants