[HOLD for payment 2023-06-05] [HOLD] [Moderation] Create Report.flagReportAction

[dangrous]

Part of NewDot Moderation - Tracking Issue and Design Doc

Design Doc Section

---

Once we have the flag data sent to us by using one of the severity options detailed above, we will need to send it to the backend for handling. We will create a new function in Report.js called FlagComment, which will take as parameters (reportActionID, user, severity).

The function will generate the optimisticData by adding the appropriate flag severity and decision to the message, as well as the RBR in case something goes wrong.

if (severity === 'Spam' || severity === 'Inconsiderate') {
	let decision = 'flagged';
} else {
	let decision = 'pending';
}

let newDecision = {
	"decision": decision,
};

let updatedDecisions = [...(message.moderationDecisions || []), newDecision];

const updatedMessage = {
...message,
moderationDecisions: updatedDecisions,

};

const optimisticReportActions = {
[reportActionID]: {
pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
message: [updatedMessage],
},
};

const optimisticData = [
{
onyxMethod: CONST.ONYX.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, value: optimisticReportActions,
},
];

const failureData = [
{
onyxMethod: CONST.ONYX.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`,
value: {
[reportActionID]: {
...originalReportAction,
                    pendingAction: null,
},
},
},
];

const successData = [
{
onyxMethod: CONST.ONYX.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`,
value: {
[reportActionID]: {
pendingAction: null,
},
},
},
];

In case of failure, we just return the original message.

We’ll then send the data to the api with a write command:

const parameters = {
reportID,
severity,
reportActionID: reportAction.reportActionID,
};
API.write(‘FlagComment’, parameters, {optimisticData, failureData});

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[dangrous]

will get to this next week!

[melvin-bot]

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Add Report.flagComment command #19405

If no regressions arise, payment will be issued on 2023-06-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dangrous]

Not a bug, grabbing a teammate to help with payment for @allroundexperts's review.

[kevinksullivan]

Sounds good. Payment is $1000 @dangrous ?

[dangrous]

@kevinksullivan yep!

[kevinksullivan]

Hey @allroundexperts , I sent an offer for the job

https://www.upwork.com/jobs/~0131aae97657676ce2

Let me know when you accept and I'll get this paid out!

[allroundexperts]

Hey @allroundexperts , I sent an offer for the job

https://www.upwork.com/jobs/~0131aae97657676ce2

Let me know when you accept and I'll get this paid out!

Accepted, thanks!

[kevinksullivan]

paid out. Upwork won't let me cancel the contract so I'll set a reminder to come back to it