[HOLD for payment 2023-05-23] [$1000] [Manual Requests] Ensure correct amount is displayed in the IOUPreview

[luacmartins]

Coming from this comment, transaction amounts for Expense reports are stored as negative values in the database, so we need to invert the sign from negative to positive and vice-versa.

This is because there are instances where you can get a credit back on your card, or you enter a negative expense to “offset” future expenses. So in theory, the total of your expenseReport could be a negative.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a4895d6068712f5
• Upwork Job ID: 1656413205162098688
• Last Price Increase: 2023-05-10

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a4895d6068712f5

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @mollfpr You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@mollfpr it might be clear from the body but just noting this applies only for the expense reports, not for the IOU reports

[mollfpr]

@mountiny Yes, this only happen on the expense reports.

[trjExpensify]

Dope, are you good with a PR for this one @mollfpr?

[mollfpr]

@trjExpensify Yup! Will clean up my tasks on the proposals review and then raise a PR for this.

[trjExpensify]

Neat, thanks!

[mollfpr]

App/src/libs/actions/IOU.js

Line 79 in 5df596f

moneyRequestReport.total += amount;

transaction amounts for Expense reports are stored as negative values in the database

@luacmartins in building an optimistic expense report based on the above comment, should we subtract the amount rather than increase it?

We have this glitch in the expense report

Screen.Recording.2023-05-11.at.22.06.44.mov

[luacmartins]

Yes, we should do that

[melvin-bot]

🎯 ⚡️ Woah @mollfpr / @sobitneupane / @mollfpr, great job pushing this forwards! ⚡️

The pull request got merged within 2 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @mollfpr got assigned: 2023-05-10 21:41:41 Z
• when the PR got merged: 2023-05-12 10:19:15 UTC

On to the next one 🚀

[luacmartins]

PR merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Invert amount money request amount from negative to positive and vice-versa  #18783

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr / @sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr / @sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr / @sobitneupane] Determine if we should create a regression test for this bug.
• [@mollfpr / @sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

[@mollfpr / @sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr / @sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr / @sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a bug. This issue is another work for #18537.

[@mollfpr / @sobitneupane] Determine if we should create a regression test for this bug.
[@mollfpr / @sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Propose regression step.

1. Go to the workspace report
2. Request money using the action menu item
3. Put any amount
4. Submit the requested money
5. Verify that the IOU preview is shown with a positive amount
6. Verify that the amount on the Expense report that just added in LHN has a positive amount
7. Navigate to the Expense report that just added
8. Verify that the report header shows a positive amount
9. Back to the workspace report and do request money again
10. Verify again step 5, 6, and 8
11. 👍 or 👎

[luacmartins]

IMO we don't need regression steps for this case specifically. A negative amount is quite obvious and would get the testers attention.

[mollfpr]

Make sense to me!

[trjExpensify]

Alrighty, time to settle up here. Sorry for the delay, as I get back from EC3.

I've sent the following offers on this job:

@mollfpr - $1,500 for the fix & #urgency bonus
@sobitneupane - $1,500 for C+ & #urgency bonus

[trjExpensify]

Settled up with @mollfpr. Awaiting @sobitneupane!

[sobitneupane]

@trjExpensify I didn't review the PR. So, no payment for me.

[trjExpensify]

Ah cool, got it. Thanks! Closing this out then. 👍