Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-15] Update styling in mentions auto-suggestion component #18795

Closed
puneetlath opened this issue May 11, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@puneetlath
Copy link
Contributor

puneetlath commented May 11, 2023

Right now, it looks like this:

image

We want it to look like this:

image

From Figma:
Avatar:

width: 24px;
height: 24px;
border-radius: 400px;

Display name:

width: 82px;
height: 20px;
font-family: 'Expensify Neue';
font-style: normal;
font-weight: 700;
font-size: 15px;
line-height: 20px;

/* Product/Dark/Text */

color: #E7ECE9;

Email address:

width: 166px;
height: 20px;
font-family: 'Expensify Neue';
font-style: normal;
font-weight: 400;
font-size: 15px;
line-height: 20px;


/* Product/Dark/Supporting Text */
color: #AFBBB0;

Also note, there is no dash between the name and the email address in the figma mockup.

@szebniok do you want to take this one?

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f4639a0ec44a830a
  • Upwork Job ID: 1666844506242052096
  • Last Price Increase: 2023-06-08
@puneetlath puneetlath added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 11, 2023
@puneetlath puneetlath self-assigned this May 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

@melvin-bot

This comment was marked as off-topic.

@puneetlath
Copy link
Contributor Author

cc @shawnborton in case there's anything you want to change about the style.

@shawnborton
Copy link
Contributor

Nope, mock looks good to me!

@melvin-bot melvin-bot bot added the Overdue label May 15, 2023
@szebniok
Copy link
Contributor

Hey @puneetlath, I'll take this

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

@puneetlath, @szebniok, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

@puneetlath
Copy link
Contributor Author

PR is in review.

@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

@puneetlath, @szebniok, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

@puneetlath, @szebniok, @sobitneupane Still overdue 6 days?! Let's take care of this!

@puneetlath
Copy link
Contributor Author

Just merged.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title Update styling in mentions auto-suggestion component [HOLD for payment 2023-06-15] Update styling in mentions auto-suggestion component Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter n/a
  • Contributor that fixed the issue n/a
  • Contributor+ that helped on the issue and/or PR @sobitneupane

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot

This comment was marked as off-topic.

@puneetlath puneetlath added the Internal Requires API changes or must be handled by Expensify staff label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f4639a0ec44a830a

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

@puneetlath puneetlath removed their assignment Jun 8, 2023
@puneetlath puneetlath added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

@puneetlath
Copy link
Contributor Author

@sobitneupane sent you a contract. No need for the checklist on this one. This wasn't really a bug. More of a new feature.

@slafortune adding you since I'll be OOO when it's time to pay.

@puneetlath puneetlath self-assigned this Jun 8, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 14, 2023
@slafortune
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

5 participants