[HOLD for payment 2023-05-25] QR code share polish issues

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

3 bugs:

## Action Performed:

Go to settings >Share code

## Expected Result:
should not show any Console error

---

## Action Performed:

1. Go to settings >Profile >Display name
2. type long first and last name
3. Go to settings >Share code
4. check the name in Share code

## Expected Result:
Name cuts both side

## Actual Result:
Name should not cut

---

## Action Performed:

1. Login ND
2. Open Settings

## Expected Result
It is centered

## Actual Result:
It's not

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: yes
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @aman-atg @gadhiyamanan twice
Slack conversation:

https://expensify.slack.com/archives/C049HHMV9SM/p1684148520784279
https://expensify.slack.com/archives/C049HHMV9SM/p1684146498776949
https://expensify.slack.com/archives/C049HHMV9SM/p1684146466609189

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Prince-Mendiratta]

Related issue - #18970
Posted a proposal for the same, which I think can be used here - #18970 (comment)

[mountiny]

@chrispader

[chrispader]

heyoo github 👋🏼

[robertjchen]

Got some feedback from Design as well, should be an easy text color tweak. Let me know if I can help! 👍 #18080 (comment)

[chrispader]

@mountiny @robertjchen the PR is ready for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bug fixes: QR codes #18946

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kevinksullivan]

@mountiny was this an external issue? It seems like yes, and we'll pay out @chrispader for the PR?

[mountiny]

@kevinksullivan Chris is from Margelo agency so they will handle payments differently

we just need to pay @aman-atg and @gadhiyamanan for reporting the bugs I believe. I think it would be $250 each

[kevinksullivan]

Sorry for the delay, was OOO. @aman-atg @gadhiyamanan I just sent you both offers. Let me know when you accept and I can close this out!

https://www.upwork.com/jobs/~0188e019cd152b6790

[gadhiyamanan]

@kevinksullivan i think offer should be $500($250 for each bug) to report two different bugs

[kevinksullivan]

@mountiny maybe I misunderstood your input here? Both @gadhiyamanan and @aman-atg should be paid for reporting two individual bugs?

[aman-atg]

@kevinksullivan Accepted the offer accepted, thank you.

[mountiny]

@kevinksullivan sorry its a bit unclear, I have combined 3 reports to this issue as they were all connected and related to one feature added and the original author fixed them all in one PR.

so we got:

• $250 to @aman-atg
• $500 to @gadhiyamanan for 2 reports.

[kevinksullivan]

@gadhiyamanan can you accept the offer? I'll add $250 to it.

[kevinksullivan]

Paid @aman-atg

[gadhiyamanan]

@kevinksullivan accepted, thanks!

[kevinksullivan]

Paid @gadhiyamanan . Now upwork is giving me the "modal of death" where I can't continue finishing up the contract 🙃 . I'll come back around to closing out the contract.

[mountiny]

This is being handled

[kevinksullivan]

Ah sorry this can be closed anyways since I paid everyone. i'll close out the job now.