Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN background color is not correct. #1967

Closed
2 tasks
parasharrajat opened this issue Mar 20, 2021 · 5 comments · Fixed by #1979
Closed
2 tasks

LHN background color is not correct. #1967

parasharrajat opened this issue Mar 20, 2021 · 5 comments · Fixed by #1979
Assignees

Comments

@parasharrajat
Copy link
Member

parasharrajat commented Mar 20, 2021

If you haven’t already, check out our contributing guidelines for onboarding!


There are a couple of styling issues.

  • LHN Bg color.
  • LHN Chat hover style.

Expected Result:

Screenshot_2021-03-20 Expensify cash - Chat with friends to send and receive money

Actual Result:

Screenshot_2021-03-20 Expensify cash - Chat with friends to send and receive money(1)

Platform:

Web
iOS
Android
Desktop App
Mobile Web

@parasharrajat
Copy link
Member Author

@shawnborton I think due to migration to the react-navigation we missed this. I noticed when hovering over the row there was no effect on the LHN. Please confirm if this is legit. I have PR ready to fix this.

@shawnborton
Copy link
Contributor

Good catch @parasharrajat! You are correct, your bug is legit. For your PR, you might also want to make sure the color of the LHN matches the color of the status bar on iOS - I vaguely recall there being a small discrepancy there.

@parasharrajat
Copy link
Member Author

parasharrajat commented Mar 22, 2021

Ok. the color of LHN bg should match the status bar bg color.

@shawnborton
Copy link
Contributor

Yes, but think of it the other way around - the status bar should match the LHN (gray1). Then when we navigate to a chat, the status bar should match the background color of a chat (white).

@parasharrajat
Copy link
Member Author

Oh yeah. Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants