[HOLD for payment 2023-06-07] [Awaiting bug report payment on June 5th] App crashes when opening report as anonymous user

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

• Sign out
• Open a public room (like the ExpensiConX #announce room)
• Verify you can see the announce room as an anonymous user (random email).
• Click on Sign in or any action that should not be allowed to an unauthenticated user
• Verify you're redirected to the signin page
• Enter email/phone
• Enter magic code
• Verify you can see the public room in the LHN

Expected Result:

• App should not crash

Actual Result:

• App crashed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Reproducible in staging?:
Reproducible in production?:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1685451659037849

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.

[Julesssss]

CC @situchan

[Julesssss]

Removing blocker label as the fix was CPd

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix crash when open report for anonymous user #19818

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Julesssss] The PR that introduced the bug has been identified. Link to the PR:
• [@Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Julesssss] Determine if we should create a regression test for this bug.
• [@Julesssss] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

Sent an offer to @situchan!

[situchan]

This is not a normal external contributing flow but as I fixed this issue (I am the PR author), I think I am also eligible for normal compensation. Maybe timeline bonus applies as well?
The proposal is accepted on slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1685451659037849

[kadiealexander]

Thank you for linking that Slack thread, looks like you did a lot of work on this! Since the PR was merged within a few hours of this issue being opened, I'm happy to pay:

Reporting bonus: $250
Payment for PR: $1000
Speed bonus: $500

@Julesssss would you agree?

[situchan]

This was first reported by @mountiny so not eligible for reporting bonus.

[kadiealexander]

Thanks for flagging!

[kadiealexander]

@Julesssss just bumping for a buddy check on the payment above please!

[Julesssss]

@Julesssss would you agree?

Sorry, yeah that looks good to me!

[kadiealexander]

@situchan I've sent you a new offer here, please accept and I'll get this paid.

[situchan]

@kadiealexander thanks, accepted.

[kadiealexander]

All paid! Thanks @situchan.