[HOLD for payment 2023-07-21] [$2000] Web - Quick actions menu is below the welcome message when user invited to a room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Pre-req: open the latest version of Safari browser on iOS mac. Then make the browser full screen mode.

1. From Account A, make a room (public)
2. Set the Welcome message that has a word wrapped in backticks, as the following:

Hello

3. Copy the link to the room
4. Copy the link to safari and join from account B.
5. Post a message
6. Hover on the message

Expected Result:

The quick actions menu should be displayed on top of the upper welcome message

Actual Result:

The quick actions menu is cut off due to the welcome message on safari

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Safari
• MacOS / Desktop

Version Number: 1.3.20.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-27.at.1.48.01.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @esh-g

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685176705589209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2648eb123a606dc
• Upwork Job ID: 1664832387031658496
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[esh-g]

The welcome message should be: (Just anything with the code syntax)
```
Hello
```

[sethraj14]

@michaelhaxhiu @esh-g Unable to reproduce this issue, but found another issue while debugging this issue.

Welcome message shows empty spaces and does not trim the message.

This can be fixed using this proposal -

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty space in the welcome message.

What is the root cause of that problem?

There is not trimming of welcome message.

What changes do you think we should make in order to solve the problem?

We should trim the Welcome message before saving in this function -

    const submitForm = useCallback(() => {
        Report.updateWelcomeMessage(props.report.reportID, props.report.welcomeMessage, welcomeMessage.trim());
    }, [props.report.reportID, props.report.welcomeMessage, welcomeMessage]);

This will trim the welcome message and will not show empty messages.

What alternative solutions did you explore? (Optional)

[esh-g]

@sethraj14 Are you on Safari?

[sethraj14]

@esh-g Yes tried on safari as well.

[melvin-bot]

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[michaelhaxhiu]

Hmm this is an issue with backticks it seems 🤔. @esh-g did you manage to reproduce without backticks or only when those are used?

[esh-g]

@michaelhaxhiu I was able to repro with backticks only..

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2648eb123a606dc

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[HaiderKeshwani]

Hi,
I think this could be an issue due to z-index. Maybe increasing the z-index of the quick actions of the below message can solve it, or even decreasing the Welcome message z-index can also work.

[melvin-bot]

📣 @HaiderKeshwani! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[HaiderKeshwani]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~017c967b928c091725

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[sethraj14]

Finally able to reproduce the issue, it is only happening in a safari full-screen mode. Very specific and also happens intermittently, if you hover back and forth a few times over the welcome message and new message, the issue sometimes disappears.

FYI @mananjadhav @esh-g @michaelhaxhiu

[ginsuma]

#22268 PR is up.
cc: @mananjadhav

[melvin-bot]

@deetergp, @mananjadhav, @flodnv, @ginsuma, @michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[deetergp]

Keep your shirt on Melvin, the PR is under review.

[michaelhaxhiu]

😂

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix code block messages overlap context menu in Safari #22268

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

Because this is a very platform specific change, and with a specific scenario (full-screen), I don't think we can link it to any offending PR.

Neither I am sure if we should be adding Full Screen Safari, to the checklist? . Lastly, I think we don't need a regression test for this scenario? Open to feedback here. @michaelhaxhiu @deetergp wdyt?

[michaelhaxhiu]

Pay day on a friday 😸! Summary:

• @esh-g External issue reporter $250
• @ginsuma Contributor that fixed the issue $2000
• @mananjadhav Contributor+ that helped on the issue and/or PR - paid via newDot $2000

[michaelhaxhiu]

New upwork job link (last one expired) - https://www.upwork.com/jobs/~010aae0f1247cf26f2

[michaelhaxhiu]

@ginsuma & @esh-g can you please apply for this job? I can't find your upwork profiles

[ginsuma]

@michaelhaxhiu I applied.

[mananjadhav]

I accidentally only raised for 1500. Adding another request of 500. I thought it was a $1K job and the bonus applied, because I counted from PR date. But we calc from assigned time.

@anmurali You might see two requests - 1500 and 500 for this one. 🤦

[esh-g]

@michaelhaxhiu Applied on upwork! This is my profile: https://www.upwork.com/freelancers/tanyag4

[anmurali]

Approved $1500 + $500 for this job

[michaelhaxhiu]

Just waiting for @esh-g to accept my offer and then I can pay/close this.

[esh-g]

@michaelhaxhiu Thanks! I accepted the offer