Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-06] [HOLD App#20694] mWeb - Task - Assignees email is beyond the screen #20566

Closed
1 of 6 tasks
kbecciv opened this issue Jun 10, 2023 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Jun 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #20032

Action Performed:

  1. Open NewDot on mWeb
  2. Go to any chat
  3. Create a task and assign it to account with long email
  4. Go to chat again

Expected Result:

Assignee email should be within the frame

Actual Result:

Assignee email is beyond the frame

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6087884_video_72__2_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jun 10, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 10, 2023

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Jun 10, 2023

Issue is not reproduced in production

Screenshot_20230610_101009_Chrome

@situchan
Copy link
Contributor

situchan commented Jun 11, 2023

I managed to find the offending PR which introduced this bug: #20114
I have solution to fix both #19717 and #19934 but as this is within regression period, I think they will handle this.
It seems like that PR caused several regressions. Maybe better fully revert.

@melvin-bot melvin-bot bot added the Overdue label Jun 12, 2023
@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 12, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jun 13, 2023
@Beamanator Beamanator changed the title mWeb - Task - Assignees email is beyond the screen [HOLD App#20694] mWeb - Task - Assignees email is beyond the screen Jun 14, 2023
@Beamanator
Copy link
Contributor

Looks like this is being fixed in #20694

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

@Beamanator Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

@Beamanator Eep! 4 days overdue now. Issues have feelings too...

@Beamanator Beamanator added Weekly KSv2 and removed Daily KSv2 labels Jun 27, 2023
@Beamanator
Copy link
Contributor

Still on hold for #20694

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 29, 2023
@melvin-bot melvin-bot bot changed the title [HOLD App#20694] mWeb - Task - Assignees email is beyond the screen [HOLD for payment 2023-07-06] [HOLD App#20694] mWeb - Task - Assignees email is beyond the screen Jun 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 5, 2023
@Beamanator
Copy link
Contributor

Payment being discussed here - #19717 (comment)

and will be handled in that issue - closing out!

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants