[$1000] Only "mark as unread" present in deleted message in main but it's not the case with staging

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat and send image
2. Click on reply thread option
3. On a new thread page, delete the attachment and refresh the page
4. After deleted message appears, hover on it and it just shows mark as unread. However on staging, all the options are available.

Expected Result:

Either mark as unread should not be present for deleted message or emoji option should also be present

Actual Result:

Only mark as unread present in deleted message in main but it's not the case with staging

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: main
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686831763770099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01434e6d5b981d683c
• Upwork Job ID: 1669329085854871552
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01434e6d5b981d683c

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Triggered auto assignment to @mountiny (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only "mark as unread" present in deleted message in main but it's not the case with staging

What is the root cause of that problem?

We are checking here to hide Emoji with Deleted Message

shouldShow: (type, reportAction) => type === CONTEXT_MENU_TYPES.REPORT_ACTION && _.has(reportAction, 'message') && !ReportActionUtils.isMessageDeleted(reportAction),

What changes do you think we should make in order to solve the problem?

In case we still want to show the emoji for Deleted Message, we should remove !ReportActionUtils.isMessageDeleted(reportAction) in above condition.

In case we want to hide Mark as Read option from deleted message we should add more condition to the menu item of mark as read option:

 shouldShow: (type) => type === CONTEXT_MENU_TYPES.REPORT_ACTION && !ReportActionUtils.isMessageDeleted(reportAction)

What alternative solutions did you explore? (Optional)

N/A

[raphaelppp]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The visibility of the "mark as unread" action does not take into account whether the report item has been deleted.
This applies both to the context menu and the icons that appear on hover in the chat room.

What is the root cause of that problem?

The "shouldShow" function in ContextMenuActions.js is not as comprehensive for "mark as unread" as it is for other actions.

What changes do you think we should make in order to solve the problem?

Modify the relevant "shouldShow" function in ContextMenuActions.js.

[dhairyasenjaliya]

hey @johncschuster its expected to hide all the icons, only mark as unread is displayed for deleted message on purpose context here #20074 (comment) and this issue can be closed

[mountiny]

@dhairyasenjaliya @priya-zha has this really not been repro in staging/ production. I feel like this is intentional and this is not a bug as the comment deleted is a parent of a thread, hence we do not remove it from the history.

[dhairyasenjaliya]

@mountiny its expected to hide all the icons, only mark as unread is displayed for deleted message on purpose context here recently this has been fixed to remove on purpsoe #20074 (comment) and this issue can be closed

[priya-zha]

@mountiny This issue today is repro on staging as well. Though, it wasn't present on staging when the issue was posted on Slack. According to #20074 ,it seems like it's intended, therefore, we can close this issue if it's not a bug. Thanks.

[mountiny]

Thanks for confirming I will go ahead and close this issue as a feature not a bug