Unable to access private room on staging but shows a page with composer on production

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot at first and login with User A (an incognito window might be good for this)
2. Create a new workspace and invite User B
3. Create a new room in PRIVATE mode on the Workspace you just created.
4. Send a message to that room
5. Click on the header of the room > Share code > Copy URL to clipboard.
6. In another web chrome, login on staging.new.expensify.com with User B and paste the URL on the tab on User B side
7. Result: See that on User B, it shows 'unable to access the chat' even when the User B was invited to the room
8. Follow the same steps on production app and see that 'Unable to access' message is not shown. Instead a blank page with chat composer is shown. Inconsistency between staging and production environment is seen

Expected Result:

Should be able to access private room on staging

Actual Result:

Unable to access private room on staging but shows a page with composer on production

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-14_11.45.56.mp4

Recording.979.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686722925761399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a9b420914de094eb
• Upwork Job ID: 1669474116334002176
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

Thanks @avi-shek-jha for asking in the Slack thread that, if it's on staging only, should it be a deploy blocker. I asked https://expensify.slack.com/archives/C049HHMV9SM/p1686867131810959?thread_ts=1686722925.761399&cid=C049HHMV9SM and internally.

@amyevans wasn't sure about internal/external

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a9b420914de094eb

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[cead22]

@mallenexpensify @kavimuru are we certain the conversation should actually load, and that what we're seeing on staging isn't by design? The thing is, the video doesn't show the channel actually loading, it just shows the skeleton UI that suggests it's loading

[cead22]

cc @dukenv0307 @fedirjh @aldo-expensify is it possible this is by design, and was implemented in this PR?

[mallenexpensify]

I wondered the same thing @cead22 . But "Private" appears to mean "Private to the workspace", so the chat should load if a user is a member of the workspace (as it does on production). Since this is a deploy blocker, let me test again

[mallenexpensify]

Tested again and was able to reproduce

[mallenexpensify]

Discussing here
https://expensify.slack.com/archives/C01GTK53T8Q/p1686868596435629

[cead22]

Maybe this isn't caused by that PR since it is on staging and production, so the behavior from the PR should be the same on both

[mallenexpensify]

Upon multiple retests (where I double checked I was logged in on both production for User B with the correct accounts) I was unable to produce.

Where I think the problem is is that, when creating a new room, we state People invited to this room can find it and... there's no way I can find to invite people to the room.

[melvin-bot]

@mallenexpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Bumping to weekly since it needs reproduction and/or it might be a feature request? Will dig in soon-ish

[mallenexpensify]

Still need to look into

[mallenexpensify]

I'm going to close this for now since I wasn't able to reproduce and Vit mentioned this a few weeks ago

I am not sure about the each behaviour either but we definitely do not have the invite flow implemented.

I think we're planning on addressing this flow but it'll take a while to get everything fleshed out