Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group creation - Not enough space between circle and edge #2123

Closed
isagoico opened this issue Mar 27, 2021 · 6 comments · Fixed by #2104 or #2158
Closed

Group creation - Not enough space between circle and edge #2123

isagoico opened this issue Mar 27, 2021 · 6 comments · Fixed by #2104 or #2158
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment

Comments

@isagoico
Copy link

isagoico commented Mar 27, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Expected Result:

I am expecting to see more space between edge and circle.

Actual Result:

Not enough space between circle and edge

Action Performed:

  1. Go to https://staging.expensify.cash/
    and login
  2. Click on the green plus button
  3. Click on New Group

Platform:

Where is this issue occurring?

Web ✔️ (android mWeb and iOS mWeb)
iOS
Android
Desktop App ✔️
Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Video

image

Expensify/Expensify Issue URL:

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label Mar 27, 2021
@isagoico isagoico changed the title mWeb - When creating a group, the icons on the right side of the panel did not disappear Group creation - Not enough space between circle and edge Mar 27, 2021
@shawnborton
Copy link
Contributor

@parasharrajat looks like our padding changes in this PR broke this: #2015

Perhaps the most ideal scenario is that each row has padding for both left and right, and all of the additional components (like the checkbox, draft icon, pin icon, etc) are all nested inside of the padded area. Let me know if that makes sense and if that is possible.

@parasharrajat
Copy link
Member

@shawnborton checking it

@roryabraham roryabraham self-assigned this Mar 29, 2021
@roryabraham
Copy link
Contributor

@parasharrajat Any update on this one? Are you working towards a solution?

@roryabraham
Copy link
Contributor

Looking at this comment makes me think you do have a solution pending, so I'm going to assign this issue to you.

@parasharrajat
Copy link
Member

@roryabraham fix has been added to #2104.

@roryabraham
Copy link
Contributor

@parasharrajat As part of our new deploy process, if issues are found in the staging environment which are not present in production, they will be marked as DeployBlockerCash, and that means we won't run a production deploy until they're resolved. Therefore, could you possibly add just the fix to this issue to its own PR so I can quickly review so we can hopefully run a production deploy today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants