[HOLD for payment 2023-07-14] Web- A Green 'Yes, Continues' button is shown when closing an account.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to settings
2. Click on Security and then choose Close Account
3. Write your default contact method and click on Close Account.
4. Notice that "Closing your account cannot be undone" message pops up with a Green 'Yes, Continues' button.

Expected Result:

A Red 'Yes, Continues' button is shown

Actual Result:

A Green 'Yes, Continues' button is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test45_Closinggreenbutton-1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688188374632229

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[parasharrajat]

This was missed accidentally during the refactoring of the concerned component. Refactor PR was on hold for a long time and this change was done during that period. It got overlooked during the merge conflict resolution.

I have created a PR to solve it.

[parasharrajat]

@dylanexpensify you either assign an engineer here or wait for the PR to be merged. No C+ will be required here because I was C+ on original PR.

This was the original PR #19328 which caused this issue. To speed up the things, I am creating the PR being C+ on it.

[dylanexpensify]

Ah nice, thanks for the context @parasharrajat! How long do you think it will take for the PR to be merged? This will help inform if I assign an engineer here!

[parasharrajat]

As soon as an engineer is assigned to merge it. PR is #22251

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green "Yes,Continue" button instead of red button when closing an account

What is the root cause of that problem?

App/src/pages/settings/Security/CloseAccountPage.js

Lines 111 to 120 in 4f9f428

	<ConfirmModal
	title={props.translate('closeAccountPage.closeAccountWarning')}
	onConfirm={onConfirm}
	onCancel={hideConfirmModal}
	isVisible={isConfirmModalVisible}
	prompt={props.translate('closeAccountPage.closeAccountPermanentlyDeleteData')}
	confirmText={props.translate('common.yesContinue')}
	cancelText={props.translate('common.cancel')}
	shouldShowCancelButton
	/>

There is no danger props here. This is the root cause
This was from #19328

What changes do you think we should make in order to solve the problem?

Add danger props to the ConfirmModal component

This works as expected.

What alternative solutions did you explore? (Optional)

[dylanexpensify]

this is intentional!

[parasharrajat]

Is the green button intentional? Did you confirm this @dylanexpensify?

[situchan]

It seems the discussion happened in #20130 and landed on red color for consistency.

[bondydaa]

not sure this should have been closed, I merged the PR. sorry for missing this while doing the refactor.

[dylanexpensify]

Oh wow, sorry, yes agree - this shouldn't have been - my fault!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Modal type in close Account confirmation #22251

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Reviewing today!

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Refactor CloseAccountPage to functional component #19328

• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor CloseAccountPage to functional component #19328

• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA

• [@parasharrajat] Determine if we should create a regression test for this bug. No

• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Not required

[dylanexpensify]

@parasharrajat any payments needed here?

[parasharrajat]

@dylanexpensify There will be reporting bonus payment.

I am not sure about the payment for work done by me. If you think a basic payout($250) should be done for efforts then yes. I jumped in quickly to prevent duplicate issues from popping up. Here we fixed an issue caused during refactoring PR done by internal Engineers where I was C+.

[dylanexpensify]

@daveSeife mind applying here?

@parasharrajat we're discussing rewards for preventing duplicates, but currently nothing in stone! TY though! LMK if you think this should require payment though

[avalonprod]

Hi, I understand your problem and I know how to solve this problem.

1. Create a unique class with prefix RED or Delete
2. Write styles for this class background-color: #fb642a
3. Test
4. Send for testing and comment on corrections.
5. Executed and delivered.

Thanks. Roman

[melvin-bot]

📣 @avalonprod! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[avalonprod]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/roman2022

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[daveSeife]

@dylanexpensify I have applied. Thank You!

[parasharrajat]

@dylanexpensify I think Yes. Does $250 look good to you?

[dylanexpensify]

Sounds good!

[dylanexpensify]

@daveSeife sent offer, @parasharrajat mind applying?

[parasharrajat]

@dylanexpensify I will request this later.

[parasharrajat]

Requested payment 250.

[dylanexpensify]

payment sorted, closing out

[JmillsExpensify]

Reviewed details for @parasharrajat. This is accurate based on the agreement from @dylanexpensify above, as the Business Reviewer. This is approved for payment in NewDot.