[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] [$1000] Task thread gets hidden when clicking on other chats

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on FAB > Assign task > Give title > Click next > Click on Assignee > select a user > Click Confirm task
2. While task thread is open click on other chats

Expected Result:

Task thread should not disappear

Actual Result:

Task thread disappears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-05.22.24.41.mp4

Recording.1173.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1688585231083709
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0172c3507dab16a468
• Upwork Job ID: 1677064497764429824
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task thread gets hidden when clicking on other chats.

What is the root cause of that problem?

The root cause is that task thread have a empty lastMessageText, so ReportUtils.shouldReportBeInOptionList returns false, and then gets hidden in LHN.

App/src/libs/ReportUtils.js

Lines 2021 to 2024 in 197cf7d

	// Hide thread reports that haven't been commented on
	if (isThread(report) && !report.lastMessageText) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

We can change above code as below.

-   if (isThread(report) && !report.lastMessageText) {
+   if (isThread(report) && !isTaskReport(report) && !report.lastMessageText) {

What alternative solutions did you explore? (Optional)

None.

[Li357]

Thanks @StevenKKC -- I don't we should hide any actionable items either, such as IOUs, expenses, etc. So we should only hide 1:1s, group chats, and threads that haven't been commented on. Since this is also a deploy blocker, can you get a PR in by EoD? If not, I'll pick this up.

[c3024]

@jeet-dhandha answered earlier in #22294

[Li357]

Seems like @jeet-dhandha did propose first. Since this is a deploy blocker I'm going to go ahead and do the fix myself.

[Julesssss]

The proposal makes sense to me, but I'm curious why this was only a recent regression. Nothing from yesterday's checklist seems like an obvious cause for this issue 😕

[jeet-dhandha]

@Li357 should i do anything ?

[Li357]

No, we'll handle this internally since it involves fixing this not just for tasks

[jeet-dhandha]

Sure 👌

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide only chat threads that haven't been commented on #22349

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allroundexperts]

@kevinksullivan I'll be getting paid through the App. Please delete the Upwork request.

[kevinksullivan]

@jeet-dhandha can you elaborate on what you're asking for? Thanks

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide only chat threads that haven't been commented on #22349

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[anmurali]

@allroundexperts - paid

[jeet-dhandha]

@kevinksullivan just wanted a compensation for help. But then it got fixed by an internal member saying its a priority so no worries. Its okay on your end.

[Nathan-Mulugeta]

Hey @anmurali are payments being processed early?

[allroundexperts]

Hey @anmurali are payments being processed early?

No. I think mine was processed earlier due to a mistake.

I'll complete the checklist now.

This was a deploy blocker and I just got paid for the review. So I don't think checklist is applicable here.

[Nathan-Mulugeta]

Hey guys when is this report's Payment going to be processed? I am seeing two hold for payments on the title. @kevinksullivan

[maddylewis]

i am assigned this issue - #22294

should i be issuing a reporting bonus on my issue? is a second reporting bonus, the Contributor and C+ payments being processed via this issue?

[kevinksullivan]

Paid @Nathan-Mulugeta

[kevinksullivan]

should i be issuing a reporting bonus on my issue? is a second reporting bonus, the Contributor and C+ payments being processed via this issue?

That seems to be a duplicate of this GH @maddylewis . Does the problem still exist now that this has deployed?

[esh-g]

@kevinksullivan @maddylewis Sorry for the late reply but that issue was opened 44 mins before this issue. I think this would be the dupe. I'm sorry I didn't notice it before

[maddylewis]

ok ok word - ty for clarifying, all 👍