Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-01-17] [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript #24997

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Closed

[HOLD for payment 2024-01-17] [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript #24997

melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Assignees
@sakluger @grgia @alitoshmatov
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023 •
edited
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ConfirmPopover.js 5
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0188b659c6107dd46b
  • Upwork Job ID: 1748446884337414144
  • Last Price Increase: 2024-01-19
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2023
@kubabutkiewicz kubabutkiewicz mentioned this issue Oct 31, 2023
Merged
58 tasks
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@kubabutkiewicz kubabutkiewicz mentioned this issue Dec 14, 2023
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Jan 2, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 3, 2024

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@alitoshmatov
Copy link
Contributor

@grgia Waiting for your take on this PR - #33112

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 10, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript [HOLD for payment 2024-01-17] [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript Jan 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 10, 2024
@grgia grgia added the NewFeature Something to build that is a new item. label Jan 17, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 17, 2024

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Jan 17, 2024
@grgia
Copy link
Contributor

grgia commented Jan 17, 2024

@sakluger could you help with $500 C+ payment to @alitoshmatov for the PR #33112

@alitoshmatov
Copy link
Contributor

alitoshmatov commented Jan 17, 2024 •
edited
Loading

I think payment for TS migration issues are $125 or $250. Not sure about this

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 17, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@sakluger sakluger changed the title [HOLD for payment 2024-01-17] [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript Jan 19, 2024
@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Jan 19, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0188b659c6107dd46b

@sakluger sakluger removed the Internal Requires API changes or must be handled by Expensify staff label Jan 19, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 19, 2024

Current assignee @alitoshmatov is eligible for the Internal assigner, not assigning anyone new.

@sakluger sakluger changed the title [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript [HOLD for payment 2024-01-17] [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript Jan 19, 2024
@sakluger
Copy link
Contributor

TS Migration issues are $250. @alitoshmatov I sent you an offer in Upwork, please let me know once you've accepted it. Thanks!

@sakluger sakluger added Daily KSv2 and removed Weekly KSv2 labels Jan 19, 2024
@alitoshmatov
Copy link
Contributor

Accepted the offer

@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@sakluger
Copy link
Contributor

Thanks! All done here 👍

@melvin-bot melvin-bot bot removed the Overdue label Jan 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakluger sakluger

@grgia grgia

@alitoshmatov alitoshmatov

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sakluger @kubabutkiewicz @grgia @alitoshmatov