Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'ErrorUtilsTest.js' test to TypeScript #25274

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 12 comments
Closed

[TS migration] Migrate 'ErrorUtilsTest.js' test to TypeScript #25274

melvin-bot bot opened this issue Aug 17, 2023 · 12 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/unit/ErrorUtilsTest.js 1
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Feb 5, 2024
@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority labels Feb 8, 2024
@mountiny mountiny reopened this Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 8, 2024
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

Copy link
Author

melvin-bot bot commented Feb 11, 2024

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mollfpr
Copy link
Contributor

mollfpr commented Feb 11, 2024

@srikarparsi The PR is ready to merge! Do I need to get compensated for the test? It's pretty simple though.

cc @jliexpensify

@jliexpensify
Copy link
Contributor

Hi @mollfpr - TS Migrations are $250, but I believe it's the same as any standard job. You should get paid out after deployment to prod.

@mollfpr
Copy link
Contributor

mollfpr commented Feb 12, 2024

Thank you @jliexpensify! Could you assign me to the issue?

Also, friendly bump @srikarparsi for the PR!

@srikarparsi
Copy link
Contributor

srikarparsi commented Feb 12, 2024

Merged :)

@jliexpensify I think we just need to pay @mollfpr $250 for reviewing the PR and we should be good to close since it was taken care of by Callstack.

@jliexpensify
Copy link
Contributor

Great, here is a PAYMENT SUMMARY for JMills:

@JmillsExpensify
Copy link

$250 approved for @mollfpr based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants