Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map not showing in DistanceRequest tab of MoneyRequest page #25696

Closed
2 of 6 tasks
lanitochka17 opened this issue Aug 22, 2023 · 11 comments
Closed
2 of 6 tasks

Map not showing in DistanceRequest tab of MoneyRequest page #25696

lanitochka17 opened this issue Aug 22, 2023 · 11 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify,com
  2. Go to + > Request money
  3. Go to Distance tab

Expected Result:

Map is displayed in Distance tab

Actual Result:

Map is not displayed in Distance tab. The site does not ask for location permission. It is not possible to set 'allow' for location permission on web browser as it reverts to 'ask' in the site settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome
  • MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173422_mweb

Bug6173422_Android

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 22, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@arosiclair arosiclair assigned arosiclair and unassigned madmax330 Aug 22, 2023
@arosiclair
Copy link
Contributor

arosiclair commented Aug 22, 2023

  • iOS ✅
  • Android ✅
  • Android Web ❌
  • iOS Web ❌
  • Desktop web ❌

@hayata-suenaga is this supposed to work on web at this point? The map doesn't seem to load on web platforms on staging

@hayata-suenaga
Copy link
Contributor

I'm checking now

@hayata-suenaga
Copy link
Contributor

that will be solved when this PR is deployed to staging. I don't know if it's worth cherry pick though because this feature is behind beta anyway.

@hayata-suenaga hayata-suenaga added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Aug 22, 2023
@hayata-suenaga
Copy link
Contributor

@arosiclair I gonna assign myself to this issue and see if the PR actually gonna fix the issue. But this is not a deploy blocker so removing the label.

@hayata-suenaga
Copy link
Contributor

yep the map is working on main

Screenshot 2023-08-22 at 3 18 23 PM

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Aug 25, 2023

being handled here: https://github.com/Expensify/Expensify/issues/311387 (internal)

UPDATE: ⬆️ this turned out not to be the cause of the issue

@melvin-bot melvin-bot bot removed the Overdue label Aug 25, 2023
@hayata-suenaga hayata-suenaga changed the title Request money - Map does not show up in Distance tab Map not showing in DistanceRequest tab of MoneyRequest page Aug 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 27, 2023
@hayata-suenaga
Copy link
Contributor

Opened a PR in the Cloudflare-Workers repo

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

@hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hayata-suenaga
Copy link
Contributor

The fix has been deployed and it's working now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants