Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Android - Notifications - Inconsistent appearing of avatar on notification when app is backgrounded #25875

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 24, 2023 · 22 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. As user A, open Newdot on any platform (that's not the android device you'll be testing with for User b)
  2. As user B, sign into NewDot app on Android then background app
  3. Send a message from A to B
  4. Notice the push notification content
  5. Repeat steps 3 and 4 until avatar doesn't show.

Expected Result:

User A's avatar should show on the push notification

Actual Result:

Inconsistent appearing of avatar image on push notification when app is backgrounded.
User B's avatar sometimes appears sometimes no

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.57-0

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6175788_Recording__797.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01961ba65022c042e0
  • Upwork Job ID: 1696678025675087872
  • Last Price Increase: 2023-09-06
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 24, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2023

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@tgolen tgolen removed the DeployBlockerCash This issue or pull request should block deployment label Aug 25, 2023
@tgolen
Copy link
Contributor

tgolen commented Aug 25, 2023

I'm going to remove the deploy blocker label and make this a normal bug.

@tgolen tgolen added Daily KSv2 and removed Hourly KSv2 labels Aug 25, 2023
@tgolen tgolen removed their assignment Aug 25, 2023
@tgolen tgolen added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Aug 30, 2023
@melvin-bot melvin-bot bot changed the title Android - Notifications - Inconsistent appearing of avatar on notification when app is backgrounded [$1000] Android - Notifications - Inconsistent appearing of avatar on notification when app is backgrounded Aug 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01961ba65022c042e0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@mallenexpensify
Copy link
Contributor

Updated reproduction steps in the OP to be a bit more clear. Was able to reproduce via BrowserStack
image

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
@Elyas-Demeke
Copy link

I would like to work on this issue

@shubham1206agra
Copy link
Contributor

Is this BE issue?
If not, can you help me point out where in the code the payload is created?

@ntdiary
Copy link
Contributor

ntdiary commented Aug 30, 2023

FYI, I just did a quick investigation and it seems this behavior might be controlled by Android system? If the same person sends more than one message, the largeIcon of subsequent messages gets hidden?
image
image

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@mallenexpensify mallenexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mallenexpensify
Copy link
Contributor

Thanks @ntdiary , do you think there's anything we can/should do about this?

@maddylewis I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@ntdiary
Copy link
Contributor

ntdiary commented Sep 5, 2023

@mallenexpensify, personally, I think this is a low priority (or not urgent) issue, because although the avatar is hidden, the username will show in the message, if this is acceptable, we can treat it as expected behavior and close this issue 😄

first message subsequent messages
image image

If we are still interested in always displaying the avatar and there are no other suggestions in the next couple days, I can dig deeper this week to confirm if it's feasible. Also, maybe we can display the avatar on the left side like Slack does (currently it's App logo)

first message subsequent messages
image image

@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@maddylewis
Copy link
Contributor

removing my assignment since it sounds like this is non-urgent/matt is back on Monday

@maddylewis maddylewis removed their assignment Sep 8, 2023
@mallenexpensify
Copy link
Contributor

Thanks @ntdiary and @maddylewis
Thinking about this more if the behaviour is intended, then this isn't a bug but a new feature, right?
And... if so... it doesn't sound like something we can or would/could easily 'fix', right?

I'm going to bump to monthly

@mallenexpensify mallenexpensify added Monthly KSv2 NewFeature Something to build that is a new item. and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Current assignee @mallenexpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Sep 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2023
@mallenexpensify mallenexpensify added Monthly KSv2 and removed Weekly KSv2 labels Sep 21, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@mallenexpensify
Copy link
Contributor

Gonna close based on comments above, since the flow is intended, I don't foresee us doing a bunch of work to change/update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

8 participants