User is unable to authenticate with magic link

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate to sig-up page
2. Enter email & click on 'Continue' button
3. Open email > copy magic link > open new tab
4. Paste to browser address bar & prefix the link with dev link in the following format: http://localhost:8082/v/15361796/136890
5. Press enter
6. Switch to the tab where user was trying to sign in

Expected Result:

User should be signed in

Actual Result:

User is not signed in until the user refreshes the page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692948638904319

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

I know @tgolen is out for the rest of the day, grabbing this

[roryabraham]

This is not reproducible on staging, so not a deploy blocker.

[NicMendonca]

@kavimuru I am unable to reproduce this 👀

[Natnael-Guchima]

Hello @NicMendonca, did you try on development environment? I think the issue only exists on dev currently.

[tgolen]

@Natnael-Guchima Does it work if you manually enter the code?

[Natnael-Guchima]

@tgolen yes it works fine when you entered the magic code manually

[tgolen]

OK, thanks! For this particular issue, is it a frontend issue, or a backend issue? I don't really understand the flow that's happening in the description.

Since this only impact local development, and it works when entering the code manually, I think we can probably just close this issue.

[Natnael-Guchima]

Once user pastes the magic and pressed enter key, they should be navigated into the app, rather the they are stuck at enter magic code page. The same flow works fine on staging.

[tgolen]

is it a frontend issue, or a backend issue?

[Natnael-Guchima]

I am not sure. But I guess it is front-end issue that is related to navigation.

[tgolen]

Could you please try some of the following and add the information to this issue?

• Look at JS console for any errors
• Look at the network requests to see if requests are successful
• For requests that are successful for validating the magic code, can you please include their requestID in case I need to look up the logs for those requests on the server?

[Natnael-Guchima]

@tgolen

Response to the request:
{
"httpCode": 200,
"jsonCode": 200,
"authResponseMessage": "200 OK",
"requestID": "7fdee47cc8ef11ac-MRS"
}

Console log:

Now the issue is reproducible on staging:

Screencast.from.2023-08-28.22-12-36.mp4

And it works fine on prod:

Screencast.from.2023-08-28.22-14-14.mp4

[tgolen]

OK, thank you! @johnmlee101 or @NikkiWines Do either of you might know what's going on here?

[johnmlee101]

Has this always worked on staging? Some random part in the back of my subconscious thinks this flow only worked on prod but I can't for the life of me remember why. However the fact that the page just kind of sticks is very odd. Let me test and see

[johnmlee101]

Okay I couldn't reproduce on staging but it was realllllllly slow. Which honestly feels like a performance regression. It took like 10 seconds to load the page, and another 5 seconds after to actually update the original sign in page with the code

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Natnael-Guchima]

@tgolen this issue is now reported by applause as a deploy blocker here

[tgolen]

I'm going to close this issue as a duplicate.

[Natnael-Guchima]

@tgolen my report came first. The duplicate one is the one reported by applause. Can you please add my name on the other issue as a reporter?

[tgolen]

Sure, updated 👍

[Natnael-Guchima]

Thanks 👍