Fetching report history on reconnect is inefficient and causes issues for sign out

[marcaaron]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Expected Result:

If we already have local report actions for a report we don't need to fetch them again.
If we log out quickly after logging in the app does not end up in a bad state.

Actual Result:

Even though we are up to date on a report's history we will still re-download the 50 most recent items on reconnect
If we log in and out quickly the app appears to get caught in some kind of infinite loop.

Actions Performed:

1. Be me
2. Have chat history already downloaded
3. Go offline and back online
4. See that we are fetching the history for all reports and returning up to 50 comments we already have for each

1. Sign in and sign out quickly
2. See that the app tries to make API requests that it should not and gets caught in some sort of infinite loop.

Workaround:

This mostly leads to performance issues like slowdowns from having to re-download things we've already got.

Platform:

Where is this issue occurring?

Everywhere

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork