Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat Switch timing does not accurately reflect the test we want to perform #2683

Closed
marcaaron opened this issue May 4, 2021 · 1 comment · Fixed by #2684
Closed

Chat Switch timing does not accurately reflect the test we want to perform #2683

marcaaron opened this issue May 4, 2021 · 1 comment · Fixed by #2684
Assignees
@marcaaron
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@marcaaron
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Expected Result:

Grafana data should reflect the total time it takes to tap on a chat and view the messages in that chat

Actual Result:

Grafana data only reflects the time it takes for a report to mount and the contents still takes some time to render

Action Performed:

  1. Switch to a chat
  2. See that the timing log fires well before the chat messages are loaded

Workaround:

None

Platform:

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork
@marcaaron marcaaron self-assigned this May 4, 2021
@marcaaron marcaaron mentioned this issue May 4, 2021
Merged
5 tasks
@marcaaron
Copy link
Contributor Author

Original context in this Slack thread

@marcaaron marcaaron added Weekly KSv2 Reviewing Has a PR in review labels May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcaaron marcaaron

Labels
Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Chat Switch timing in Grafana so it waits for all messages to layout Expensify/App
1 participant
@marcaaron