Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - App crashes when tapping back arrow on request money screen #2694

Closed
isagoico opened this issue May 5, 2021 · 12 comments · Fixed by #2707
Closed

Android - App crashes when tapping back arrow on request money screen #2694

isagoico opened this issue May 5, 2021 · 12 comments · Fixed by #2707
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@isagoico
Copy link

isagoico commented May 5, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Expected Result:

App should work without any issues

Actual Result:

App crash only when tapping the back arrow.

Action Performed:

  1. Launch the app
  2. Log in with expensifail account
  3. Select any user
  4. Click on Plus button and select Request Money
  5. Put any amount and Click Next
  6. In Field What's it for? - put some text
  7. Tap on back arrow twice.

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.36-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Video

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@isagoico isagoico added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels May 5, 2021
@MelvinBot
Copy link

Triggered auto assignment to @RachCHopkins (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 5, 2021
@isagoico
Copy link
Author

isagoico commented May 5, 2021

Another issue affecting the IOU beta this time only on android, marking as deploy blocker. @Julesssss if you disagree this should be a DB please go ahead and remove the label :)

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label May 5, 2021
@Julesssss Julesssss added Improvement Item broken or needs improvement. and removed DeployBlockerCash This issue or pull request should block deployment labels May 5, 2021
@Julesssss
Copy link
Contributor

Thanks, @isagoico. Removing the blocker label as it isn't a common flow yet.

@Julesssss
Copy link
Contributor

Julesssss commented May 5, 2021

Confirmed the crash is occurring on Android, no matter if the comment is set or not.

Web is showing a console error at the same place if you quickly navigate back through the steps. Not convinced this is related, but it's the best guess I have currently.

Native device logs aren't helpful, but leaving them here anyway:

Screenshot 2021-05-05 at 11 54 59

@Julesssss

This comment has been minimized.

@Julesssss
Copy link
Contributor

This also occurs if you request money from a chat (skipping the participants step), so I'm marking the above comment as outdated.

@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label May 5, 2021
@MelvinBot
Copy link

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Julesssss Julesssss removed the External Added to denote the issue can be worked on by a contributor label May 5, 2021
@Julesssss
Copy link
Contributor

On Second thoughts, we'll leave the IOI blockers internal. Please ignore the label :)

@marcaaron marcaaron self-assigned this May 5, 2021
@marcaaron
Copy link
Contributor

I can reproduce this pretty easily gonna take a stab at it.

@marcaaron
Copy link
Contributor

It seems the crash only happens when the software keyboard is open.

@marcaaron
Copy link
Contributor

Using InteractionManager.runAfterInteractions() seems to fix this. Dismissing the keyboard and navigating to the previous step seems to be too much for Android to handle.

@marcaaron
Copy link
Contributor

Ah ha. I think it is caused by the dismiss behavior of the screen

https://reactnavigation.org/docs/stack-navigator/#keyboardhandlingenabled

Since the back button is in the left gutter for where the "swipe" occurs the keyboard is dismissed but then reappears when we are transitioning to the next view and then 💥

Fix incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants