Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] New chat / New group animation gets stuck #2710

Closed
isagoico opened this issue May 6, 2021 · 18 comments
Closed

[HOLD] New chat / New group animation gets stuck #2710

isagoico opened this issue May 6, 2021 · 18 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2

Comments

@isagoico
Copy link

isagoico commented May 6, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Expected Result:

New chat or New group get should work smoothly after opened from plus tab

Actual Result:

New chat or New group get stuck after opened from plus tab

Action Performed:

  1. Go to https://staging.expensify.cash
  2. Log in with any account
  3. Click on Green Plus
  4. Select a New Chat
  5. Click on X (exit)
  6. Click on Green Plus
  7. Select a Group Chat

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
mWeb ✔️ (iOS Safari)
Android
Desktop App
Mobile Web

Version Number: the issue is repro 2 out of 5

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Important: this is not reproducible every time. The issue is repro 2 out of 5 times.

Bug5054367_chat.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@isagoico isagoico added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels May 6, 2021
@MelvinBot
Copy link

Triggered auto assignment to @RachCHopkins (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 6, 2021
@isagoico isagoico changed the title New chat or New group animation gets stuck New chat / New group animation gets stuck May 6, 2021
@RachCHopkins
Copy link
Contributor

Can I just clarify - is this on the iOS app, or is it in the Web app, accessed via iOS? Are we focussing on Safari mobile, here as opposed to the iOS app?

@isagoico
Copy link
Author

isagoico commented May 6, 2021

Oh yes! Let me fix that.

@RachCHopkins
Copy link
Contributor

Hmmm. Ok I am not getting the same behaviour here. If I choose a person or people whom I have an existing chat with, it's fine. Then I choose a new person I have never chatted to and it is just blank. I refresh and it's back to the chat list view.

If I choose the same person a second time, it does create a new message. Video shows:

  1. Message JLi - no issue
  2. Message Amal (who I tested with earlier) - creates new chat
  3. Message Clem (who I have never messaged before) - blank page
SafariTest.mp4

Same behaviour on Chrome. @isagoico I'm not sure if what I see is just another version of the issue you see or something else - can you please try creating a message to the same person again, after it gets 'stuck'? And see if the issue only occurs with people you do not have an existing chat with?

@marcaaron
Copy link
Contributor

@RachCHopkins the blank screen thing is a 🐛 so this will probably go back to being weirdly broken again after we fix the other bug.

@marcaaron
Copy link
Contributor

I think it's possible @parasharrajat's issue and proposals here will also maybe address this -> #2335

Current theory is that these modals get wonky because the animations are driven in the JS and can break when we are doing too much work while transitioning.

@RachCHopkins
Copy link
Contributor

@marcaaron I can't replicate it. Should I close this for now if we think it will be remedied in due course?

@marcaaron
Copy link
Contributor

Maybe let's put a HOLD on it instead so we can make sure it gets resolved. I've seen this before, but it can be hard to repro.

@parasharrajat
Copy link
Member

Sure, @marcaaron I believe that If we fix the jank behavior then this would be resolved as well.

@isagoico
Copy link
Author

isagoico commented May 9, 2021

Issue reproducible during today's KI retests

@RachCHopkins RachCHopkins added Engineering Improvement Item broken or needs improvement. Weekly KSv2 and removed Daily KSv2 labels May 10, 2021
@MelvinBot
Copy link

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@RachCHopkins RachCHopkins removed their assignment May 10, 2021
@marcaaron marcaaron changed the title New chat / New group animation gets stuck [HOLD] New chat / New group animation gets stuck May 10, 2021
@marcaaron
Copy link
Contributor

Putting a HOLD on this so we can see if Rajat's changes in review here will fix this

@isagoico
Copy link
Author

Issue reproducible during today's KI retests

1 similar comment
@isagoico
Copy link
Author

Issue reproducible during today's KI retests

@isagoico
Copy link
Author

Issue not reproducible today during KI retests (First Week)

@isagoico
Copy link
Author

isagoico commented Jun 7, 2021

Issue not reproducible today during KI retests (Second Week)

@parasharrajat
Copy link
Member

Just to inform you that I think this was fixed in #2956.

@isagoico
Copy link
Author

Issue not reproducible today during KI retests (Third Week) - Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants