Workspace - Company type dropdown in Adding bank account page (Step 2) is broken

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Workspace > any workspace > Bank account
3. Click Add manually
4. Proceed to Step 2
5. Click on the Company type dropdown

Expected Result:

Company type dropdown is not broken

Actual Result:

Company type dropdown is broken

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69-10

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6198919_20230913_183042.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Proposal

Problem

Company type dropdown in Adding bank account page (Step 2) is broken

Root cause

we are mapping a translation key which is a string to picker items.

Changes

Create a array with incorporation types in constants, map the array to items like below, in Companystep

       items={_.map(CONST.INCORPORATION_TYPES, (value) => ({ value: translate(`companyStep.incorporationTypes.${value}`),
       label: translate(`companyStep.incorporationTypes.${value}`) }))}

[dummy-1111]

This is a regression of this PR

[getusha]

Dupe of #27326

[AndrewGable]

Looks like this is going to be fixed by #27358

[srikarparsi]

Closing this one out since it's fixed here