[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL #28026

kavimuru · 2023-09-22T15:45:24Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Start a chat.
Navigate to the "Assign task" section.
Enter a title and create the task.
After task creation, click on the assignee.
Copy the URL of the assignee modal and send it.
Proceed to cancel the task.
After canceling, click on the sent link

Expected Result:

Upon opening the assignee page of the canceled task using the URL, the "Hmm... it's not here" message should be displayed for the assignee

Actual Result:

The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.73-0
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-09-22.16-41-37-895.mp4

screen-recording-2023-09-18-at-92636-pm_GqYXLtcn.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695054791232689

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0181644eb19fd0aac9
Upwork Job ID: 1705246939905851392
Last Price Increase: 2023-09-29
Automatic offers:

ahmedGaber93 | Contributor | 27047586

ahmedGaber93 · 2023-09-22T15:45:25Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL

What is the root cause of that problem?

The root cause is when a task is deleted, the parentReportAction is updated to have a isDeletedParentAction deleted flag
but here when we check if task isOpen we use the task.report instead report

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Lines 201 to 203 in 4969433

    
           const isOpen = ReportUtils.isOpenTaskReport(props.task.report); 
        
           const canModifyTask = Task.canModifyTask(props.task.report, props.currentUserPersonalDetails.accountID); 
        
           const isTaskNonEditable = report && ReportUtils.isTaskReport(props.task.report) && (!canModifyTask || !isOpen);

isOpenTaskReport

App/src/libs/ReportUtils.js

Lines 220 to 222 in 4969433

    
           function isOpenTaskReport(report, parentReportAction = {}) { 
        
               return isTaskReport(report) && !isCanceledTaskReport(report, parentReportAction) && report.stateNum === CONST.REPORT.STATE_NUM.OPEN && report.statusNum === CONST.REPORT.STATUS.OPEN; 
        
           }

isOpenTaskReport use isCanceledTaskReport which failed in task.report

App/src/libs/ReportUtils.js

Lines 201 to 211 in 4969433

    
           function isCanceledTaskReport(report = {}, parentReportAction = {}) { 
        
               if (!_.isEmpty(parentReportAction) && lodashGet(parentReportAction, ['message', 0, 'isDeletedParentAction'], false)) { 
        
                   return true; 
        
               } 
        
               if (!_.isEmpty(report) && report.isDeletedParentAction) { 
        
                   return true; 
        
               } 
        
               return false; 
        
           }

What changes do you think we should make in order to solve the problem?

We need to use report instead of task.report when we check isOpen.
and this is the same way that used in TaskDescriptionPage.js here and TaskTitlePage.js here

we can also use it in canModifyTask and isTaskReport (optional)

// we use the same page for both new task asignee and edit it,
// so we need to check it because in new task report will be null 
// we can also use Boolean(report)
const isOpen = report && ReportUtils.isOpenTaskReport(report);

The report && because this page used for both new task and edit task.

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2023-09-22T15:45:29Z

Job added to Upwork: https://www.upwork.com/jobs/~0181644eb19fd0aac9

melvin-bot · 2023-09-22T15:45:29Z

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-22T15:45:31Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-22T15:45:33Z

Triggered auto assignment to @miljakljajic (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-09-22T15:45:39Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

dukenv0307 · 2023-09-23T00:47:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL

What is the root cause of that problem?

We only update props.task.report when TaskView is rendered. When we cancel the task report, this component is unmounted, and then prop.task.report is not updated.

App/src/components/ReportActionItem/TaskView.js

Lines 45 to 47 in 71db96d

    
           useEffect(() => { 
        
               Task.setTaskReport({...props.report}); 
        
           }, [props.report]);

So this check here is wrong

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 204 in 71db96d

const isOpen = ReportUtils.isOpenTaskReport(props.task.report);

What changes do you think we should make in order to solve the problem?

In TaskAssigneeSelectorModal, TaskTitlePage, TaskDescriptionPage, we should add a useEffect to update props.task.report with report

useEffect(() => {
    Task.setTaskReport({...report});
}, [report]);

Let's imagine this case when we open the task report which is not canceled and then we open the assignee modal of the canceled task, props.task.report will be the data of the previous task report or when we open assignee modal before signing, because TaskView is not rendered, props.task.report will be empty. So we should update prop.task.report on each page above.

What alternative solutions did you explore? (Optional)

We can still display TaskView with a strike-through style for the canceled task or add a description to know the task is canceled

miljakljajic · 2023-09-25T03:33:18Z

Triaged and reproduced:

miljakljajic · 2023-09-25T03:33:37Z

@sophiepintoraetz do we both need to be assigned to this? If not, feel free to unassign yourself.

sophiepintoraetz · 2023-09-25T05:19:24Z

@miljakljajic - no, we don't 😂 I can take this seeing as I was assigned first (thank you for replicating, as an FYI, if Applause has applied the External label, this implies they are able to reproduce the bug and so we don't have to)

miljakljajic · 2023-09-25T05:21:05Z

Oh brilliant I had no idea, thank you!

miljakljajic · 2023-09-25T05:21:18Z

Appreciate you grabbing it also <3

sophiepintoraetz · 2023-09-28T08:20:44Z

Waiting for @robertKozik to review the proposals!

melvin-bot · 2023-09-29T16:00:11Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

sophiepintoraetz · 2023-10-02T09:30:00Z

Still waiting on @robertKozik here!

melvin-bot · 2023-10-13T22:06:40Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-13T22:06:45Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix displaying not found page in TaskAssigneeSelectorModal.js #29029

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ahmedGaber93 requires payment offer (Contributor)
@robertKozik does not require payment (Contractor)
@ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:06:47Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@robertKozik] Determine if we should create a regression test for this bug.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-13T22:58:08Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix displaying not found page in TaskAssigneeSelectorModal.js #29029

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ahmedGaber93 requires payment offer (Contributor)
@robertKozik does not require payment (Contractor)
@ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:58:10Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@robertKozik] Determine if we should create a regression test for this bug.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:20:40Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix displaying not found page in TaskAssigneeSelectorModal.js #29029

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ahmedGaber93 requires payment offer (Contributor)
@robertKozik does not require payment (Contractor)
@ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:20:42Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@robertKozik] Determine if we should create a regression test for this bug.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:46:26Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix displaying not found page in TaskAssigneeSelectorModal.js #29029

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ahmedGaber93 requires payment offer (Contributor)
@robertKozik does not require payment (Contractor)
@ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:46:28Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@robertKozik] Determine if we should create a regression test for this bug.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-23T12:27:22Z

@ahmedGaber93, @sophiepintoraetz, @srikarparsi, @robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick!

sophiepintoraetz · 2023-10-23T20:59:54Z

Summary of payments:

Reporter: @ayazhussain79 - $50
Contributor: @ahmedGaber93 $500 (plus $250 urgency bonus)
C+: N/A

Eligible for urgency bonus? Y

sophiepintoraetz · 2023-10-23T21:00:11Z

@robertKozik - can you complete the b0 checklist please?

ayazhussain79 · 2023-10-23T21:09:59Z

@sophiepintoraetz offer accepted, Thank you

kavimuru added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 22, 2023

melvin-bot bot changed the title ~~The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL~~ [$500] The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL Sep 22, 2023

melvin-bot bot assigned sophiepintoraetz Sep 22, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 22, 2023

melvin-bot bot assigned miljakljajic Sep 22, 2023

melvin-bot bot assigned robertKozik Sep 22, 2023

melvin-bot bot added the Overdue label Sep 25, 2023

melvin-bot bot removed the Overdue label Sep 25, 2023

miljakljajic removed their assignment Sep 25, 2023

melvin-bot bot added the Overdue label Sep 27, 2023

melvin-bot bot removed the Overdue label Sep 28, 2023

melvin-bot bot added the Overdue label Oct 2, 2023

melvin-bot bot removed the Overdue label Oct 2, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

isabelastisser removed their assignment Oct 17, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 20, 2023

melvin-bot bot removed the Overdue label Oct 23, 2023

sophiepintoraetz closed this as completed Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL #28026

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL #28026

kavimuru commented Sep 22, 2023 •

edited by melvin-bot bot

Loading

ahmedGaber93 commented Sep 22, 2023 •

edited

Loading

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023 •

edited by miljakljajic

Loading

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

dukenv0307 commented Sep 23, 2023 •

edited

Loading

miljakljajic commented Sep 25, 2023

miljakljajic commented Sep 25, 2023

sophiepintoraetz commented Sep 25, 2023

miljakljajic commented Sep 25, 2023

miljakljajic commented Sep 25, 2023

sophiepintoraetz commented Sep 28, 2023

melvin-bot bot commented Sep 29, 2023

sophiepintoraetz commented Oct 2, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 •

edited by sophiepintoraetz

Loading

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 23, 2023

sophiepintoraetz commented Oct 23, 2023

sophiepintoraetz commented Oct 23, 2023

ayazhussain79 commented Oct 23, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL #28026

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] The "Hmm... it's not here" message does not appear when opening the assignee modal of a canceled task using the URL #28026

Comments

kavimuru commented Sep 22, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

ahmedGaber93 commented Sep 22, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023 • edited by miljakljajic Loading

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

dukenv0307 commented Sep 23, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

miljakljajic commented Sep 25, 2023

miljakljajic commented Sep 25, 2023

sophiepintoraetz commented Sep 25, 2023

miljakljajic commented Sep 25, 2023

miljakljajic commented Sep 25, 2023

sophiepintoraetz commented Sep 28, 2023

melvin-bot bot commented Sep 29, 2023

sophiepintoraetz commented Oct 2, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 • edited by sophiepintoraetz Loading

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 23, 2023

sophiepintoraetz commented Oct 23, 2023

sophiepintoraetz commented Oct 23, 2023

ayazhussain79 commented Oct 23, 2023

kavimuru commented Sep 22, 2023 •

edited by melvin-bot bot

Loading

ahmedGaber93 commented Sep 22, 2023 •

edited

Loading

melvin-bot bot commented Sep 22, 2023 •

edited by miljakljajic

Loading

dukenv0307 commented Sep 23, 2023 •

edited

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by sophiepintoraetz

Loading