Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Infinite loading spinners when trying to launch anything from the CreateMenu #2825

Closed
trjExpensify opened this issue May 12, 2021 · 3 comments · Fixed by #2833
Closed

[iOS] Infinite loading spinners when trying to launch anything from the CreateMenu #2825

trjExpensify opened this issue May 12, 2021 · 3 comments · Fixed by #2833
Assignees
@Christinadobrzyn
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Improvement Item broken or needs improvement.

Comments

@trjExpensify
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Expected Result:

Tapping on a menu item should launch the page nice and quickly!

Actual Result:

Tapping any of the menu items results in an infinite loading spinner that doesn’t resolve itself.

Action Performed:

  1. Tap the + icon
  2. Tap New Chat
  3. Observe the infinite loading spinner
  4. Click the X
  5. Tap New Group
  6. Observe the infinite loading spinner once again

Workaround:

Nope.

Platform:

Web
iOS ✔️
Android
Desktop App
Mobile Web

Version Number: v1.0.42-2

Notes/Photos/Videos:

Image from iOS (23)

Image from iOS (22)

View all open jobs on Upwork
@trjExpensify trjExpensify added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 Improvement Item broken or needs improvement. labels May 12, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 12, 2021
@trjExpensify
Copy link
Contributor Author

Can confirm this also happens when accessing the Search page. 👍

@Jag96 Jag96 added the DeployBlockerCash This issue or pull request should block deployment label May 12, 2021
@OSBotify OSBotify mentioned this issue May 12, 2021
Closed
36 tasks
This was referenced May 12, 2021
Merged
Merged
@roryabraham
Copy link
Contributor

I was able to determine that this PR introduced this regression. Reverting it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Christinadobrzyn Christinadobrzyn

Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Improvement Item broken or needs improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "fixed modal animations" Expensify/App
5 participants
@Jag96 @MelvinBot @trjExpensify @roryabraham @Christinadobrzyn