Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Sent images are not displayed in chat #2844

Closed
kavimuru opened this issue May 13, 2021 · 6 comments · Fixed by #2933 or #2935
Closed

Chat - Sent images are not displayed in chat #2844

kavimuru opened this issue May 13, 2021 · 6 comments · Fixed by #2933 or #2935
Assignees

Comments

@kavimuru
Copy link

kavimuru commented May 13, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Expected Result:

The picture I have uploaded is visible

Actual Result:

Uploaded pictures aren't displayed

Action Performed:

  1. Go to https://staging.expensify.cash
  2. Choose Chat C
  3. I press plus then ADD Attachment

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: 1.0.43-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5066089_Recording__83.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @JmillsExpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1620853811137000

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label May 13, 2021
@kavimuru kavimuru added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 13, 2021
@MelvinBot
Copy link

Triggered auto assignment to @johncschuster (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 13, 2021
@isagoico isagoico added the Daily KSv2 label May 13, 2021
@johncschuster johncschuster removed their assignment May 13, 2021
@MelvinBot
Copy link

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@johncschuster
Copy link
Contributor

@thienlnam I've reproduced this on Staging. Here's a side-by-side of staging v. production.

2021-05-13_17-34-53

@roryabraham roryabraham removed the DeployBlockerCash This issue or pull request should block deployment label May 13, 2021
@roryabraham
Copy link
Contributor

While this is pretty serious, it is no longer a deploy blocker, because we ran a production deploy today while testing changes to the Expensify.cash deploy code. So now this bug is even more urgent, since it is on production. 😉

@thienlnam
Copy link
Contributor

Prioritizing this and looking into it now

@thienlnam
Copy link
Contributor

Found the issue, trying to use withLocalize in RenderHTML was making it so that the tags were not recognized as images and not going through our image handling, working on a fix so we can still use localization there

Screen Shot 2021-05-14 at 10 45 32 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants