[$250] Request money - Scan report detail screen is not scrollable on small screen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.83.10

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @aman-atg

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697145768795909

Action Performed:

Precondition: Use small screen iPhone device (iPhone 6s)

1. Login to New Expensify app
2. Tap FAB
3. Select Request money > Scan tab
4. Split Bill with two accounts
5. Tap Split button on confirmation page
6. Tap on created IOU report
7. Try to scroll through the page

Expected Result:

Detail IOU report fiields should be scrollable so user can navigate to Description, Date and Merchant sections

Actual Result:

Scan report detail screen is not scrollable on small screen
This bug occurs when Receipt scan is in progress and also when completed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Bug6235651_1697189754772.GBRN5901.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d54d1098c90181f8
• Upwork Job ID: 1712827802614779904
• Last Price Increase: 2023-10-20

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

I can reproduce this on Android too. However, I don't think it's bad enough to block the deploy so I'm going to remove the label.

[Julesssss]

Android

screen-20231013-144044.2.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d54d1098c90181f8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[aman-atg]

I reported this here. Please update the reporter if my report was posted before the QA

cc: @kbecciv @m-natarajan

[melvin-bot]

Upwork job price has been updated to $250

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill detail page is not scrollable.

What is the root cause of that problem?

The problem is that MoneyRequestConfirmationList inside SplitBillDetailsPage component is not inside a ScrollView which should have been as in MoneyRequestConfirmPage as indicated below.

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 340 to 348 in 6251e65

	<ScrollView contentContainerStyle={[styles.flexGrow1]}>
	<ScrollView
	horizontal
	contentContainerStyle={[styles.flex1, styles.flexColumn]}
	>
	<MoneyRequestConfirmationList
	transactionID={props.iou.transactionID}
	hasMultipleParticipants={iouType.current === CONST.IOU.MONEY_REQUEST_TYPE.SPLIT}
	selectedParticipants={participants}

What changes do you think we should make in order to solve the problem?

We need to insert MoneyRequestConfirmationList in SplitBillDetailsPage component inside a ScrollView as in MoneyRequestConfirmPage.
Change

App/src/pages/iou/SplitBillDetailsPage.js

Lines 120 to 123 in 6251e65

	{isScanning && <MoneyRequestHeaderStatusBar />}
	{Boolean(participants.length) && (
	<MoneyRequestConfirmationList
	hasMultipleParticipants

to

<ScrollView contentContainerStyle={[styles.flexGrow1]}> {isScanning && <MoneyRequestHeaderStatusBar />} {Boolean(participants.length) && ( <MoneyRequestConfirmationList hasMultipleParticipants
Result:

3.New.Expensify.1.mp4

What alternative solutions did you explore? (Optional)

[Ollyws]

@FitseTLT Thanks for the proposal.
As this was happening on staging but not on production, any idea which PR introduced the regression?

[FitseTLT]

@Ollyws I don't think it is a regression because on the same SplitBillDetailPage scroll is not working with new.expensify.com. I mean, does it not mean the production?

3.New.Expensify.1.mp4

[Ollyws]

@FitseTLT I think it would have got to production by now as it was on staging when this issue was created, which has been deployed to production since.

[FitseTLT]

I checked out to a random commit (67f4f4c) from the production branch created on Oct 12 before the creation of this issue but the scroll still doesn't work.

[FitseTLT]

Checked this bug on version 1.3.83.10 but it is reproducible. I think it is incorrect that it says No to Reproducible in production at that version.

[dylanexpensify]

@Ollyws thoughts ^

[Ollyws]

I can no longer reproduce this on the lastest main, @FitseTLT can you still reproduce this?

[FitseTLT]

I can no longer reproduce this on the lastest main, @FitseTLT can you still reproduce this?

Yep it is fixed now.

[Ollyws]

Thanks for checking @FitseTLT.
@dylanexpensify This issue seems to be fixed on main now, we're good to close. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Julesssss]

Closing as resolved