[HOLD for payment 2023-11-02] [Performance] Optimize setting initial state in functional components

[sebryu]

What performance issue do we need to solve?

Setting initial state in functional components in a way that is running calculation only once

What is the impact of this on end-users?

Slightly more loading time/memory usage of multiple components (e.g parsing HTML multiple times)

List any benchmarks that show the severity of the issue

Gains may be minor, but new approach is following best practices (also discussed on slack with Expensify team )

Proposed solution (if any)

Using initializer function to useState calls. That will ensure calculations are run only once.

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

It's not optimal to collect those benchmark in this case.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sebryu]

Issue created for tracking purposes.
PR already open for review (proposal approved by engineers on slack) : #29630

[mountiny]

Adding this to the performance project and assigning myself

[mountiny]

PR merged! thanks @sebryu

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Improved initial state setting by calling initial setter only once #29630

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR