Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Android - Opening deep link of request amount page, the amount is not shown #31329

Closed
1 of 6 tasks
kbecciv opened this issue Nov 15, 2023 · 9 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Nov 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.99.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30704

Action Performed:

Pre-condition: Open same account in mweb and android

  1. Go to https://staging.new.expensify.com/
  2. Tap fab--Request money
  3. Enter an amount
  4. Tap next
  5. Select any user
  6. Tap amount
  7. Copy the link
  8. Launch app and login as same user
  9. Open any report
  10. Paste the link and send the message
  11. Tap on the link

Expected Result:

The request money page must open and the selected amount must be shown.

Actual Result:

The request money page is opened but the selected amount is not displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6276702_1700008887801._mount_not_shown.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019076fc738102f2ff
  • Upwork Job ID: 1724591213359931392
  • Last Price Increase: 2023-11-15
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 15, 2023
@melvin-bot melvin-bot bot changed the title Android - Opening deep link of request amount page, the amount is not shown [$500] Android - Opening deep link of request amount page, the amount is not shown Nov 15, 2023
Copy link

melvin-bot bot commented Nov 15, 2023

Job added to Upwork: https://www.upwork.com/jobs/~019076fc738102f2ff

Copy link

melvin-bot bot commented Nov 15, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 15, 2023
Copy link

melvin-bot bot commented Nov 15, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 15, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

@eh2077
Copy link
Contributor

eh2077 commented Nov 15, 2023

This is not a bug as the intermediate IOU data is only saved in Browser.

@narefyev91
Copy link
Contributor

Agree with comment from @eh2077. @puneetlath i think we can close this one

@monochkov
Copy link

monochkov commented Nov 15, 2023

You need to modify website URL dynamically and then pass amount along with URL to mobile.
What I mean:

  1. Dynamically change URL to the next one: https://staging.new.expensify.com/request/new/amount?value=. You can do that using JS. (https://stackoverflow.com/questions/11932869/how-to-dynamically-change-url-without-reloading). So whenever user edits amount you need to modify the URL.
  2. Handle value in mobile using deep links: https://developer.android.com/training/app-links/deep-linking#handling-intents for Android native development or https://reactnavigation.org/docs/configuring-links/#passing-params for React Native

Copy link

melvin-bot bot commented Nov 15, 2023

📣 @monochkov! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@puneetlath
Copy link
Contributor

Agreed that this isn't a bug. Closing.

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants