-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-18] Rename primitive level colors in App #32131
Comments
should it be named as |
cc @shawnborton |
I like doing something like Basically we use the names of colors for the other color columns... like green100, blue100, etc. So for product colors, I think it makes sense to call them productLight or productDark. In the future, maybe we have productLightHighContrast and productDarkHighContrast or even productDarkOrange if we had an all orange theme |
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-18. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
|
Triggered auto assignment to @conorpendergrast ( |
@conorpendergrast could you help with $500 C+ review payment to @sobitneupane |
Actually this PR fixed multiple issues. we can handle payment in #28817. Please disregard @conorpendergrast ! |
define the primitive colors as 100-800 so that it's a little cleaner to map them to theme colors
The text was updated successfully, but these errors were encountered: