Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-18] Rename primitive level colors in App #32131

Closed
grgia opened this issue Nov 28, 2023 · 10 comments
Closed

[HOLD for payment 2023-12-18] Rename primitive level colors in App #32131

grgia opened this issue Nov 28, 2023 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Nov 28, 2023

define the primitive colors as 100-800 so that it's a little cleaner to map them to theme colors

image

@grgia grgia converted this from a draft issue Nov 28, 2023
@grgia grgia self-assigned this Nov 28, 2023
@grgia grgia changed the title define the primitive colors as 100-800 so that it's a little cleaner to map them to theme colors Rename primitive level colors Nov 28, 2023
@grgia
Copy link
Contributor Author

grgia commented Nov 28, 2023

should it be named as <theme name>100 ?

@grgia
Copy link
Contributor Author

grgia commented Nov 28, 2023

cc @shawnborton

@shawnborton
Copy link
Contributor

I like doing something like productDark100 or productLight800 or something to that effect? cc @Expensify/design for thoughts too

Basically we use the names of colors for the other color columns... like green100, blue100, etc. So for product colors, I think it makes sense to call them productLight or productDark. In the future, maybe we have productLightHighContrast and productDarkHighContrast or even productDarkOrange if we had an all orange theme

@grgia grgia changed the title Rename primitive level colors Rename primitive level colors in App Nov 28, 2023
@grgia grgia moved this from Todo to In Progress in Theme Switching / Light Mode Nov 29, 2023
@grgia
Copy link
Contributor Author

grgia commented Nov 30, 2023

    // Dark Mode Theme Colors
    productDark100: '#061B09',
    productDark200: '#072419',
    productDark300: '#0A2E25',
    productDark400: '#1A3D32',
    productDark500: '#2C6755',
    productDark600: '#8B9C8F',
    productDark700: '#AFBBB0',
    productDark800: '#E7ECE9',

    // Light Mode Theme Colors
    productLight100: '#FCFBF9',
    productLight200: '#F8F4F0',
    productLight300: '#F2EDE8',
    productLight400: '#E5E1DB',
    productLight500: '#D7D1C8',
    productLight600: '#A3A9A3',
    productLight700: '#78837E',
    productLight800: '#0B2D23',
    ```

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 1, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Dec 6, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 11, 2023
@melvin-bot melvin-bot bot changed the title Rename primitive level colors in App [HOLD for payment 2023-12-18] Rename primitive level colors in App Dec 11, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 11, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 18, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2023
@grgia grgia added the NewFeature Something to build that is a new item. label Dec 20, 2023
Copy link

melvin-bot bot commented Dec 20, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Dec 20, 2023
@grgia
Copy link
Contributor Author

grgia commented Dec 20, 2023

@conorpendergrast could you help with $500 C+ review payment to @sobitneupane

@grgia
Copy link
Contributor Author

grgia commented Dec 20, 2023

Actually this PR fixed multiple issues. we can handle payment in #28817. Please disregard @conorpendergrast !

@grgia grgia closed this as completed Dec 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Merged in Theme Switching / Light Mode Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

4 participants