Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-12-18] Web/mWeb - Chat - Clicking pasted link to another conversation does not to redirect user #32608

Closed
3 of 6 tasks
lanitochka17 opened this issue Dec 7, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.9-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Log in with any account
  2. Navigate to any chat > copy its URL
  3. Navigate to another chat > send the URL in conversation
  4. Click on the link in chat

Expected Result:

User should be redirected to the chat from step 2

Actual Result:

User does not get redirected, console errors are thrown each time user clicks on the link
Android and IOS apps are crashing after taping on the link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native - app crashed
  • Android: mWeb Chrome
  • iOS: Native -app crashed
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6303853_1701910731283.2023-12-06_23-50-01.mp4

Bug6303853_1701910731289!chrome_0WtygraxWy

logs.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fbe4cb61f9d20674
  • Upwork Job ID: 1737832815130214400
  • Last Price Increase: 2023-12-21
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 7, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

I think this was me 😄 fix incoming

@situchan
Copy link
Contributor

situchan commented Dec 7, 2023

@marcaaron you were assigned in #32553 as well 😄 Shall I close?

@marcaaron
Copy link
Contributor

I closed yours, yes. Thanks! Reviewing would be helpful - should be easy since I think we wrote the exact same code 🙃

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 7, 2023
@marcaaron marcaaron added Daily KSv2 Hourly KSv2 and removed Weekly KSv2 Daily KSv2 labels Dec 7, 2023
@yuwenmemon
Copy link
Contributor

Fix was CP'ed to staging. Closing!

@situchan
Copy link
Contributor

situchan commented Dec 7, 2023

@yuwenmemon can you please keep open for C+ payment?

@yuwenmemon yuwenmemon added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 7, 2023
@yuwenmemon
Copy link
Contributor

Sounds good. Removing the label then!

@yuwenmemon yuwenmemon reopened this Dec 7, 2023
@marcaaron
Copy link
Contributor

Thanks yall

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 11, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Dec 11, 2023
@melvin-bot melvin-bot bot changed the title Web/mWeb - Chat - Clicking pasted link to another conversation does not to redirect user [HOLD for payment 2023-12-18] Web/mWeb - Chat - Clicking pasted link to another conversation does not to redirect user Dec 11, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 11, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR — @situchan paid $500 via Upwork

For reference, here are some details about the assignees on this issue:

  • @situchan requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 18, 2023
@marcaaron marcaaron added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 20, 2023
Copy link

melvin-bot bot commented Dec 20, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2023
Copy link

melvin-bot bot commented Dec 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@marcaaron
Copy link
Contributor

Added Bug label to get some help paying out @situchan

@CortneyOfstad CortneyOfstad added the External Added to denote the issue can be worked on by a contributor label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01fbe4cb61f9d20674

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-18] Web/mWeb - Chat - Clicking pasted link to another conversation does not to redirect user [$500] [HOLD for payment 2023-12-18] Web/mWeb - Chat - Clicking pasted link to another conversation does not to redirect user Dec 21, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@CortneyOfstad CortneyOfstad removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 21, 2023
@CortneyOfstad
Copy link
Contributor

@situchan I sent the job proposal to you in Upwork — please let me know as soon as you accept 👍

@CortneyOfstad
Copy link
Contributor

Payment completed! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants