Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Fix Status Bar Colors on Native #32657

Closed
grgia opened this issue Dec 7, 2023 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented Dec 7, 2023

#32512 (review)

Few issues that I noticed so far:

  • Sometimes in mWeb/Safari the color of status bar (in light mode) changes back to dark. One way to reproduce is:
  1. Go to any chat.
  2. Press on the header to open the users profile page.
Screenshot 2023-12-07 at 18 31 30
  • In IOS/native, Color of text in status bar is dark in dark mode
Screenshot 2023-12-07 at 18 37 33
  • Similarly, in Android/native, Color of text in status bar is white in light mode.
Screenshot 2023-12-07 at 18 38 51

Also related to this issue
#32591

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0167754a76c4f5604c
  • Upwork Job ID: 1744511657386971136
  • Last Price Increase: 2024-01-09
@grgia grgia converted this from a draft issue Dec 7, 2023
@grgia grgia self-assigned this Dec 7, 2023
@grgia
Copy link
Contributor Author

grgia commented Dec 7, 2023

@chrispader

@grgia grgia added the Daily KSv2 label Dec 7, 2023
@grgia grgia changed the title [Theme Switching] 🐛 Status Bar / Scrollbar colors [Theme Switching] 🐛 Fix Status Bar Colors on Native Dec 7, 2023
@chrispader
Copy link
Contributor

chrispader commented Dec 7, 2023

  • Sometimes in mWeb/Safari the color of status bar (in light mode) changes back to dark. One way to reproduce is:
  1. Go to any chat.
  2. Press on the header to open the users profile page.

@sobitneupane i can't reproduce this issue on mWeb Safari/Chrome

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-12-07.at.15.55.40.mp4

@chrispader
Copy link
Contributor

  • In IOS/native, Color of text in status bar is dark in dark mode

also can't reproduce this

Simulator Screenshot - iPhone 15 Pro - 2023-12-07 at 16 00 49

@chrispader
Copy link
Contributor

  • Similarly, in Android/native, Color of text in status bar is white in light mode.

@sobitneupane also can't reproduce Android/native:

Screenshot_1701961749

Screenshot_1701961758

@sobitneupane
Copy link
Contributor

@chrispader I was changing theme from another device. I was using adhoc web build (https://32512.pr-testing.expensify.com/) to change the theme and was testing in dev.

@chrispader
Copy link
Contributor

note to myself: #32695

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

@grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 13, 2023

@grgia Huh... This is 4 days overdue. Who can take care of this?

@grgia
Copy link
Contributor Author

grgia commented Dec 13, 2023

in progress

@chrispader
Copy link
Contributor

Ok this should have been fixed in this PR: #32672

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 13, 2023
@grgia grgia moved this to In Progress in Theme Switching / Light Mode Dec 14, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 19, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching] 🐛 Fix Status Bar Colors on Native [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Fix Status Bar Colors on Native Dec 19, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 1, 2024

@grgia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@grgia grgia added NewFeature Something to build that is a new item. Overdue labels Jan 2, 2024
Copy link

melvin-bot bot commented Jan 2, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Jan 2, 2024
@grgia
Copy link
Contributor Author

grgia commented Jan 2, 2024

@kevinksullivan could you help ensure that @situchan receives the $500 C+ review payment for review of #32672

@kevinksullivan kevinksullivan added the External Added to denote the issue can be worked on by a contributor label Jan 9, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Fix Status Bar Colors on Native [$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Fix Status Bar Colors on Native Jan 9, 2024
Copy link

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0167754a76c4f5604c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 9, 2024
Copy link

melvin-bot bot commented Jan 9, 2024

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@kevinksullivan
Copy link
Contributor

@situchan offer sent, lmk when you accept!

@melvin-bot melvin-bot bot added the Overdue label Jan 11, 2024
Copy link

melvin-bot bot commented Jan 12, 2024

@kevinksullivan, @grgia, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

@situchan
Copy link
Contributor

offer accepted already

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 12, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

@kevinksullivan, @grgia, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@grgia grgia closed this as completed Jan 17, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Merged in Theme Switching / Light Mode Jan 17, 2024
@situchan
Copy link
Contributor

@kevinksullivan payment not processed yet

@kevinksullivan
Copy link
Contributor

All set @situchan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

5 participants